Conversation
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
…work Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
…ed fixture Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Signed-off-by: Charles Graham, SWT <charles.r.graham@usace.army.mil>
Closed
1 task
MikeNeilson
reviewed
Sep 17, 2026
MikeNeilson
left a comment
Contributor
There was a problem hiding this comment.
Right so.... interesting idea and I can't say it's AI slop, it's rather easy to follow. However, it is... a lot.
Compare this to say the idea in #1955, which would end up functionally serving the same purpose while involving far less code.
Collaborator
Author
|
Closing this as it was submitted just to show some ideas/brainstorm |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prevent large time-series reads from exhausting memory and starving ordinary requests: retain bounded page data, write JSON directly, enforce response/window caps, keep JDBC deadlines request-owned, and admit eight reads with at most two bulk reads/exports. Overload returns 503 with
Retry-After; oversize reads return 413. The experimental SQL paging path remains disabled by default.Mike (@MikeNeilson) raised the large-row/concurrency issues, CSV streaming versus buffered JSON, timeout/resource pressure, and
set_session_user_directlogging overhead during this investigation. He may already have overlapping work, including HydrologicEngineeringCenter/cwms-database#230. I left these changes in this testing pass and can merge his changes into this branch while retaining the tests and comparisons.Related Issue
Related to #1955 (connection pools for different workloads). This provides load-test evidence and admission limits within the existing pool; separate connection pools remain an investigation.
Companion database PR: HydrologicEngineeringCenter/cwms-database#232. Includes the still-open #1902; account for that dependency before merging. Mike's database work: HydrologicEngineeringCenter/cwms-database#230.
Validation
Exhaustive local performance pass: four million stored observations; mixed sizes/formats; 100–1,000 actual concurrent requests; sustained arrivals, retries, stalled consumers, and recovery. Full build: 773 API unit and 79 Oracle integration tests passed (40/1 skipped); OpenAPI/client checks passed, unchanged GUI artifact reused.
“Before” below is the intermediate export-only candidate, not deployed production. “After” combines bulk admission with the companion database logging fix; these single local runs do not isolate each change's HTTP benefit.
All 675 ordinary retrying requests completed; the remaining 178 deadlines were bulk requests. All 80 recovery probes passed. Staging with live AWS settings and irregular/shared-pool traffic is still required; no production-capacity claim. No 4-GiB process memory limit was imposed locally.
Detailed results and limitations · Swagger responses
Checklist