Repository navigation
feat: require schema v2 and output-major targets - #18
Merged
Merged
Conversation
BREAKING CHANGE: Re-export bundles without schema or with schema v1. Use target_names in export and target.names in the manifest. Format 1 remains unfrozen; package version becomes 0.1.0a2.
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configuration
You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Every export now writes required schema v2 through local mlschema inference, using training features or a one-row float default. The schema records its source and bounded one-hot separator. Native model names map by name; all other origins map by zero-based feature position, with generated names starting at feature_0. Reports map by output position and use string display labels while the manifest retains verified original label types.
Replace target_name with output-major target_names, with no alias. Validate one unique bounded name per verified output, exclude every target column from training features/schema/samples, and reject target/feature overlap before publication, including overwrite. The manifest records target.names and validates count/uniqueness; the CLI displays it. Shared field/report/mapping validation remains independent of pandas/mlschema on readers.
Compatibility: bundles written by 0.1.0a1 without schema.json, or with schema version 1, are rejected and must be re-exported. The old target.name wire key and target_name export keyword are also rejected. Format version remains 1 because it is not frozen. Package version is 0.1.0a2; this PR does not publish, tag, release or merge it.
Validation: