ADR-001: Position-aware defaults and config seeding - #70
Open
UltraBob wants to merge 2 commits into
Open
Conversation
Replace the proposed DCQ_PROJECT_TYPE mode switch with position-aware runtime defaults via HostWorkingDir. The installer asks site vs contrib and seeds config accordingly; wrappers never check a mode variable. First of 10 ADRs for the ddev-module-developer merge (review order 1).
|
Instead of this being an install-time decision, could it offer to add config files based on where it is run? e.g. the first time run run it in the root directory, it will offer to add config files for the site, and the first time you run it within a module it would offer to add config files to the module |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
@mandclu I think it makes sense to start out by putting some ADRs in place for the unification. I'll be opening some PRs for these against a 2.x branch. Please check these, and express any concerns about the approaches, assumptions, or ideas in them. (or just make edits)
Hopefully that gets us onto the same page about the approach and the user experience. Then we can try to have an agent power the actual merging. In this one, I've deviated a little from the original idea of setting a mode at install. Now the installer will ask (and you could run the installer again to do both) whether you intend to maintain a site or a contrib module(s). Based on your answer we will either seed config files for the whole site, or offer to give you some starter configs in your module director(ies). Actual code quality tooling runs will mostly be based on your current directory when you run the command.
Summary
DCQ_PROJECT_TYPEmode switch with position-aware runtime defaults viaHostWorkingDir: trueThis is the keystone decision for the merge. Review order 1 of 10: all other ADRs may reference this one, but this one stands alone.
Review checklist