Skip to content

ADR-003: Config provenance and drift checking - #72

Open
UltraBob wants to merge 2 commits into
2.xfrom
adr/config-provenance-and-drift
Open

ADR-003: Config provenance and drift checking#72
UltraBob wants to merge 2 commits into
2.xfrom
adr/config-provenance-and-drift

Conversation

@UltraBob

@UltraBob UltraBob commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

  • Vendor upstream Drupal.org GitLab CI template configs verbatim
  • Keep sync-upstream-configs.sh and the weekly drift-check PR to stay current
  • Drop the runtime curl that downloads phpcs.xml.dist into the working tree at lint time
  • Seeded configs carry no #ddev-generated marker; ownership handoff to the user is total
  • ddev-module-developer's bundled configs have drifted from upstream (eslint missing airbnb-base/jsdoc, stylelint missing ignoreFiles) causing local runs to be more permissive than CI

Review checklist

  • Are there configs in ddev-module-developer beyond eslint/stylelint that have drifted from upstream?
  • Is dropping the runtime curl for phpcs.xml.dist acceptable? Any workflows that depend on it?
  • Does the fixture recalibration requirement make sense given the config parity gap?

Vendor upstream Drupal.org GitLab CI template configs verbatim with
weekly drift-check PRs. Drop the runtime curl that downloads phpcs.xml
at lint time. Seeded configs carry no #ddev-generated marker.

Review order 3 of 10.
@UltraBob

UltraBob commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

@mandclu and another

@mandclu

mandclu commented Sep 4, 2026

Copy link
Copy Markdown

My only concern is this line:

Seeded configs carry no #ddev-generated marker; ownership handoff to the user is total

Is there an alternative?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants