ADR-004: Working directory and default scope - #73
Open
UltraBob wants to merge 2 commits into
Open
Conversation
HostWorkingDir on all commands, position-aware default scope, stdin-path gating. Absorbs host-path alias idea from PR #21 as a separate piece with cross-platform testing as a prerequisite. Review order 4 of 10.
Owner
Author
|
At a high level I think scanning the custom directories when called from the root, and the cwd anywhere else makes perfect sense. I'm not sure I understand the alias risks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
HostWorkingDir: trueon every command; config discovery follows each tool's stock behavior--stdin-pathgating prevents IDE linting from triggering full-project scanspath-map.shrewrite deferred until alias is verified on macOS, Linux, and Windows/WSL2Relationship to PR #21
PR #21 bundles the host-path alias with several unrelated changes. This ADR recommends absorbing its ideas as separate 2.x changes rather than merging the PR as-is. See the "What to absorb from PR #21" and "Risks of the alias approach" sections.
Review checklist
--stdin-pathgating clear?HostWorkingDir?