Skip to content

ADR-004: Working directory and default scope - #73

Open
UltraBob wants to merge 2 commits into
2.xfrom
adr/working-directory-and-scope
Open

ADR-004: Working directory and default scope#73
UltraBob wants to merge 2 commits into
2.xfrom
adr/working-directory-and-scope

Conversation

@UltraBob

@UltraBob UltraBob commented Sep 4, 2026

Copy link
Copy Markdown
Owner

Summary

Relationship to PR #21

PR #21 bundles the host-path alias with several unrelated changes. This ADR recommends absorbing its ideas as separate 2.x changes rather than merging the PR as-is. See the "What to absorb from PR #21" and "Risks of the alias approach" sections.

Review checklist

  • Does the position-aware default scope (root = custom dirs, elsewhere = cwd) match your expectations?
  • Is the --stdin-path gating clear?
  • Are the four prerequisites reasonable before enabling HostWorkingDir?
  • Is the phased approach for the host-path alias (keep path-map.sh fallback, test cross-platform first) acceptable?
  • Any concerns about the risks listed for the alias approach?

HostWorkingDir on all commands, position-aware default scope, stdin-path
gating. Absorbs host-path alias idea from PR #21 as a separate piece
with cross-platform testing as a prerequisite.

Review order 4 of 10.
@UltraBob

UltraBob commented Sep 4, 2026

Copy link
Copy Markdown
Owner Author

@mandclu #4/10

@mandclu

mandclu commented Sep 4, 2026

Copy link
Copy Markdown

At a high level I think scanning the custom directories when called from the root, and the cwd anywhere else makes perfect sense.

I'm not sure I understand the alias risks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants