ADR-005: CI variable surface - #74
Open
UltraBob wants to merge 2 commits into
Open
Conversation
Adopt SKIP_* and _*_ALLOW_FAILURE from .gitlab-ci.yml with presence detection instead of mode gating. Per-tool variables take precedence over the blanket allow-failure flag. Review order 5 of 10.
Owner
Author
|
@mandclu this one should be easy, it is adopting your approach wholesale |
|
IIRC my goal was really to honor the variable exactly the way Gotlab CI does. If this proposes adopting the approach of ddev-module-developer that great, but ultimately the goal should always be to match the behavior of Gotlab CI |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
SKIP_*and_*_ALLOW_FAILUREvariables from.gitlab-ci.yml_ALL_VALIDATE_ALLOW_FAILURE.gitlab-ci.ymlcontains Drupal template variable patterns (presence-detected, not mode-gated per ADR-001)Review checklist
.gitlab-ci.yml) workable?