Unsigned variable with valid range, min, max bug - #1612
Merged
Merged
Conversation
PR Unidata#1603 handled the case where data are packed and the valid min, max, or range attributes were unpacked by unscaling those values. It did not try to unscale values when the variable was unsigned. However, we should only skip unscaling if the variable is unsigned because the attribute _Unsigned is set to true.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Changes
PR #1603 handled the case where data are packed and the valid min, max, or range attributes were unpacked by unscaling those values. It did not try to unscale values when the variable was unsigned. However, we should only skip unscaling if the variable is unsigned because the attribute
_Unsignedis set totrue.PR Checklist
until ready for review