Skip to content

point it to the directory instead of yes flag - #8

Merged
ocefpaf merged 4 commits into
Unidata:mainfrom
ocefpaf:fix_plugins
Oct 22, 2026
Merged

ocefpaf merged 4 commits into
Unidata:mainfrom
ocefpaf:fix_plugins

Conversation

@ocefpaf

@ocefpaf ocefpaf commented Oct 21, 2026

Copy link
Copy Markdown
Collaborator

@ocefpaf
ocefpaf marked this pull request as draft October 21, 2026 18:28
@jswhit

jswhit commented Oct 22, 2026

Copy link
Copy Markdown

suggest adding

    env:
      BUILDKIT_STEP_LOG_MAX_SIZE: -1 # Unlimited logs

to .github/workflows/build-image.yml so we can see where plugins are getting installed (right now the log is clipped when it his the 2 mb limit)

@jswhit

jswhit commented Oct 22, 2026 •

Copy link
Copy Markdown

that didn't fix the log limit for some reason - I still see

[output clipped, log limit 2MiB reached]

so I can't tell if the plugins were installed.

@ocefpaf

ocefpaf commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

Yeah. I saw some people online saying that it would only work with dockerx GHA, or some more convoluted CLI incantations. I'm build all this locally first an finding some lib vs lib64 issues that may be the culprit. I'll try to finish this tomorrow and port to dockerx if possible to get access to all the logs.

@ocefpaf
ocefpaf force-pushed the fix_plugins branch 2 times, most recently from f3398a9 to 1b9c673 Compare October 22, 2026 17:19
@ocefpaf

ocefpaf commented Oct 22, 2026 •

Copy link
Copy Markdown
Collaborator Author

@jswhit this is creating the directory /usr/local/lib/hdf5/plugin/ with what I believe are all the plugins.

sh-4.4# ls -lha /usr/local/lib/hdf5/plugin/
total 188K
drwxr-xr-x 2 root root 4.0K Oct 22 17:19 .
drwxr-xr-x 3 root root 4.0K Oct 22 17:19 ..
-rwxr-xr-x 1 root root  17K Oct 22 17:19 lib__nch5blosc.so
-rwxr-xr-x 1 root root  17K Oct 22 17:19 lib__nch5bzip2.so
-rwxr-xr-x 1 root root  16K Oct 22 17:19 lib__nch5deflate.so
-rwxr-xr-x 1 root root  17K Oct 22 17:19 lib__nch5fletcher32.so
-rwxr-xr-x 1 root root  16K Oct 22 17:19 lib__nch5shuffle.so
-rwxr-xr-x 1 root root  17K Oct 22 17:19 lib__nch5szip.so
-rwxr-xr-x 1 root root  17K Oct 22 17:19 lib__nch5zstd.so
-rwxr-xr-x 1 root root  22K Oct 22 17:19 lib__nczhdf5filters.so
-rwxr-xr-x 1 root root  22K Oct 22 17:19 lib__nczstdfilters.so

I'll work on the docker logs tomorrow. I saw two options, move to dockerx or some convuloted way to force that env. I'll check which one works best for us.


Or maybe we'll need to be smarter with the output. It looks like that won't help us much anyway: docker/build-push-action#1442 (comment)

@ocefpaf

ocefpaf commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

@ocefpaf
ocefpaf marked this pull request as ready for review October 22, 2026 18:53
@jswhit

jswhit commented Oct 22, 2026

Copy link
Copy Markdown

excellent! Once the new image is available, I'll create a new netcdf4-python release based on Unidata/netcdf4-python#1514

@ocefpaf

ocefpaf commented Oct 22, 2026

Copy link
Copy Markdown
Collaborator Author

excellent! Once the new image is available, I'll create a new netcdf4-python release based on Unidata/netcdf4-python#1514

Merging it then. Fingers crossed!

@ocefpaf
ocefpaf merged commit b686c28 into Unidata:main Oct 22, 2026
4 checks passed
@ocefpaf
ocefpaf deleted the fix_plugins branch October 22, 2026 23:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants