Accessible names for folders, files and messages - #3449
Open
FrayxRulez wants to merge 4 commits into
Open
FrayxRulez wants to merge 4 commits into
FrayxRulez wants to merge 4 commits into
Conversation
FrayxRulez
force-pushed
the
accessibility-names
branch
from
September 21, 2026 06:44
95c77a7 to
fe56e75
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Accessible names, from a pass over what the UnigramPlus NVDA add-on works around.
What it does
ChatFolderViewModel.AutomationNamecomposes the title and{n} unread chats; it is bound, not assigned, so the badge can move without the container being prepared again. The same string is what the switch announces.TextListViewItemAutomationPeer's text walk, which silently shadowed everyAutomationProperties.SetNameon a container.ProgressBars in the message surfaces; the add-on's progress-tracking feature reads the subtitle text, which is untouched.Automation.GetDescriptionis removed — it had no callers.Corrections to what I said earlier
The message name already includes reactions, the replied-to sender, the forward origin, edited/sending state and "Not seen" before the content. I had read
Automation.GetDescription, which is dead code; the live path isMessageBubble.GetAutomationName. The identity icon already names itself too, so the add-on's "Identity root" workaround is obsolete.Worth a look in review
TextListViewItem, not just folders. It should only ever add a name where one was set and ignored.AccDescrUnreadChats_one/_otheris a new string — the count is unread chats, which is what the badge counts.Not built, not tested with a reader.