Repository navigation
config-win32: do not use CryptoAPI hashing on UWP - #61
Merged
Merged
Conversation
The CryptoAPI hash functions are not available in the UWP API partition, so md5.c/sha256.c compiled with implicit declarations and Unity's UWP player failed to link (unresolved _CryptAcquireContext). Restore the CURL_WINDOWS_UWP guard so UWP uses the built-in MD5/SHA-256 again.
Match the pre-8.22 layout: HAVE_LDAP_SSL, USE_WIN32_LDAP and USE_WIN32_CRYPTO all sit under one CURL_WINDOWS_UWP guard.
simon-lemay-unity
approved these changes
Oct 19, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restore the 8.20
CURL_WINDOWS_UWPguard aroundHAVE_LDAP_SSL,USE_WIN32_LDAPandUSE_WIN32_CRYPTO, with the same layout and comment as 8.20. UWP then uses curl's built-in MD5/SHA-256 again. Desktop Windows is unchanged.Other uses of
USE_WIN32_CRYPTO(the NTLM core and MD4) are gated exactly as in 8.20, and Unity builds libcurl withCURL_DISABLE_NTLM.