chore(client): remove the unused @tanstack/react-query dependency - #4448
Open
gilgardosh wants to merge 2 commits into
Open
chore(client): remove the unused @tanstack/react-query dependency#4448gilgardosh wants to merge 2 commits into
gilgardosh wants to merge 2 commits into
Conversation
gilgardosh
temporarily deployed
to
accounter-fullstack
September 10, 2026 17:33 — with
GitHub Actions
Inactive
gilgardosh
temporarily deployed
to
accounter-fullstack
September 10, 2026 17:33 — with
GitHub Actions
Inactive
This was referenced Sep 10, 2026
Contributor
There was a problem hiding this comment.
🟢 Approval recommended
The remaining documentation nit is minor and does not block approval.
Pull request overview
Removes the unused @tanstack/react-query dependency and root provider while preserving urql and React Table usage.
Changes:
- Removed
QueryClientandQueryClientProvider. - Removed dependency and lockfile entries.
- Added changeset documentation.
File summaries
| File | Summary |
|---|---|
yarn.lock |
Removes React Query packages. |
packages/client/src/router/layouts/root-layout.tsx |
Removes the unused provider. |
packages/client/package.json |
Removes the dependency. |
.changeset/urql-drop-dead-react-query.md |
Documents the cleanup. |
.changeset/@accounter_client-4448-dependencies.md |
Records the dependency removal. |
Review note: Narrow the changeset’s “only reference” claim to live application/source references; historical references remain (nit, 1 vote).
Review details
Suppressed comments (1)
.changeset/urql-drop-dead-react-query.md:11
- This says the only reference is the root-layout import, but the repository still contains historical references in
packages/client/CHANGELOG.mdand prior dependency changesets. Narrow this to live application/source references so the release note is factually accurate.
reference anywhere in the repo was the import in `router/layouts/root-layout.tsx` that created and
mounted it; no file imports `useQuery`, `useMutation` or `useSuspenseQuery` from it. All GraphQL data
fetching goes through urql.
- Files reviewed: 4/5 changed files
- Comments generated: 0
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
The package was a declared dependency with a `QueryClientProvider` mounted at the root of the app — configured with `refetchOnWindowFocus: false` and `retry: 1` — and nothing ever used it. The only reference in the entire repo was the import in `root-layout.tsx` that created and mounted it; no file imports `useQuery`, `useMutation` or `useSuspenseQuery` from it. All GraphQL fetching goes through urql. Provider, `QueryClient` construction and dependency all removed. The surrounding `UrqlProvider > UserProvider` nesting is otherwise unchanged. `@tanstack/react-table` is a different package and is untouched — it backs every table in the app. Step 7 of the urql quick-wins sequence. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01TbrGL3NndzRiEwJkwHxnbm
gilgardosh
force-pushed
the
claude/urql-step-6-dedupe-fragments
branch
from
September 12, 2026 12:44
59be74d to
8a974ea
Compare
gilgardosh
force-pushed
the
claude/urql-step-7-drop-react-query
branch
from
September 12, 2026 12:53
c965e3a to
3dd9213
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Step 7 of 10 in the urql quick-wins sequence — tracking doc in #4437.
What changed
@tanstack/react-query@5.102.8was a declared dependency with aQueryClientProvidermounted at the root of the app — configured withrefetchOnWindowFocus: falseandretry: 1— and nothing ever used it.The only reference anywhere in the repo was the import in
root-layout.tsxthat created and mounted it. No file importsuseQuery,useMutationoruseSuspenseQueryfrom it; all GraphQL fetching goes through urql. Verified repo-wide, not just inpackages/client.Provider,
QueryClientconstruction and the dependency are all removed. The surroundingUrqlProvider > UserProvidernesting is otherwise unchanged.@tanstack/react-tableis untouchedDifferent package, and load-bearing — it backs every table in the app, and
packages/client/CLAUDE.mddocuments a v9-specific API convention around it. Onlyreact-queryis removed here. Worth a second look during review, since the two names are one character apart.Testing
Nothing to test — this removes code that was never reached. The value is in the verification that it wasn't reached, which is the grep above plus a green build.
yarn.lockis updated by the removal.🤖 Generated with Claude Code
https://claude.ai/code/session_01TbrGL3NndzRiEwJkwHxnbm
Generated by Claude Code