Repository navigation
fix(MSDK-4832): exclude x86_64 from iOS Simulator builds - #249
islameldesoky95 wants to merge 1 commit into
Conversation
…slice Native UsercentricsUI.xcframework 2.32.0 (and 2.31.1+) ships arm64-only iOS/tvOS Simulator slices — the old x86_64 fat-binary slice was reduced to a dSYM-only stub when Sentry was linked in, with EXCLUDED_ARCHS added alongside it unnecessarily (the real Sentry-Dynamic xcframework does ship x86_64). This caused test-ios CI to crash with "Test crashed with signal abrt before starting test execution" (dyld missing-slice crash) right after a successful compile+link. Root cause tracked in mobile-sdk Jira MSDK-4832, targeting a 2.32.1 patch release. Workaround: exclude x86_64 from the Pods project's iOS Simulator builds in the existing post_install hook, so Xcode never attempts to link against the broken slice. Same pattern already verified working for flutter-sdk's equivalent CocoaPods example. Regenerated Podfile.lock via `pod install` (checksum only, no dependency version changes). Could not fully verify with a real on-simulator test run locally — this dev machine is near disk capacity (same constraint noted in the release PR's own earlier verification). Recommend confirming via CI once pushed.
🤖 CodeAnt AI — Review Status
|
Thanks for using CodeAnt! 🎉We're free for open-source projects. if you're enjoying it, help us grow by sharing. Share on X · |
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Code Review by QodoSorry, something went wrongWe weren't able to complete the code review on our side. Please try again manually by commenting/agentic_review on this PR.
|
codeant-ai
Bot
added
the
size:XS
PR Summary by QodoExclude x86_64 from sample iOS Simulator Pods builds
AI Description
Diagram
High-Level Assessment
Files changed (2)
|
|
Closing — superseded. Opening a fresh release PR directly off release/2.32.0 with this fix already included instead of a separate side-PR. |
![codeant-ai[bot]](https://avatars.githubusercontent.com/in/646884?s=60&v=4){kind=small}
| # the real Sentry-Dynamic xcframework does ship x86_64). Causes a dyld "signal abrt before | ||
| # starting test execution" crash on any x86_64 Simulator destination. Exclude x86_64 here | ||
| # until a corrected native SDK version is published (tracked in mobile-sdk MSDK-4832). | ||
| config.build_settings['EXCLUDED_ARCHS[sdk=iphonesimulator*]'] = 'x86_64' |
There was a problem hiding this comment.
Suggestion: On Intel Macs, pod targets exclude x86_64 while the sample app still requests it, causing architecture mismatch during simulator linking instead of fixing the launch failure.
Assessment: 🟠 Major · 🔁 Occurrence: Rarely · 🏷️ Logic error
Prompt for AI Agent 🤖
This is a comment left during a code review.
**Path:** sample/ios/Podfile
**Line:** 87:87
**Comment:**
*Logic Error: On Intel Macs, pod targets exclude `x86_64` while the sample app still requests it, causing architecture mismatch during simulator linking instead of fixing the launch failure.
Validate the correctness of the flagged issue. If correct, How can I resolve this? If you propose a fix, implement it and please make it concise.
Once fix is implemented, also check other comments on the same PR, and ask user if the user wants to fix the rest of the comments as well. if said yes, then fetch all the comments validate the correctness and implement a minimal fix
User description
Native UsercentricsUI.xcframework 2.32.0 (and 2.31.1+) ships arm64-only iOS/tvOS Simulator slices — causes test-ios CI to crash with a dyld missing-slice abort right after a successful compile+link. Root cause tracked in mobile-sdk Jira MSDK-4832, targeting a 2.32.1 patch. Workaround: exclude x86_64 from the Pods project's iOS Simulator builds in the existing post_install hook. Same pattern already verified working for flutter-sdk's equivalent example.
Merging into release/2.32.0 (PR #248) directly since repo rules block pushing straight to that branch.
CodeAnt-AI Description
Prevent x86_64 iOS Simulator crashes caused by an unavailable native SDK slice
What Changed
Impact
✅ Fewer iOS Simulator test startup crashes✅ Reliable CI runs on arm64 Simulator destinations✅ Unaffected Sentry simulator architecture support💡 Usage Guide
Checking Your Pull Request
Every time you make a pull request, our system automatically looks through it. We check for security issues, mistakes in how you're setting up your infrastructure, and common code problems. We do this to make sure your changes are solid and won't cause any trouble later.
Talking to CodeAnt AI
Got a question or need a hand with something in your pull request? You can easily get in touch with CodeAnt AI right here. Just type the following in a comment on your pull request, and replace "Your question here" with whatever you want to ask:
This lets you have a chat with CodeAnt AI about your pull request, making it easier to understand and improve your code.
Example
Preserve Org Learnings with CodeAnt
You can record team preferences so CodeAnt AI applies them in future reviews. Reply directly to the specific CodeAnt AI suggestion (in the same thread) and replace "Your feedback here" with your input:
This helps CodeAnt AI learn and adapt to your team's coding style and standards.
Example
Retrigger review
Ask CodeAnt AI to review the PR again, by typing:
Check Your Repository Health
To analyze the health of your code repository, visit our dashboard at https://app.codeant.ai. This tool helps you identify potential issues and areas for improvement in your codebase, ensuring your repository maintains high standards of code health.