Fix the broken module links, drop the CI count, keep the design on click-through - #18
Merged
Merged
Conversation
…ick-through Four of the eight module links returned 404 in production. My earlier check had passed because python -m http.server generates directory listings and GitHub Pages does not: a folder only becomes a page if it holds a README.md, and qualitative, scripts, notebooks and python_integration do not. The tiles now link to GitHub, uniformly, which never 404s and is honest about their being R source rather than pages. The four that did resolve rendered without the site's styling at all, so clicking through left the design behind. _layouts/default.html and _config.yml now render any folder README in the house style, with the same top bar and type. The hero counted "37 Checks in CI". A reader does not care how many tests run. Replaced with the module count. Verified against a local Jekyll build, where a directory resolves only if it contains index.html: no broken internal links. Co-Authored-By: Claude Opus 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_01DMYhECx2Dzbqad6KJxWZ7t
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Four of the eight module links returned 404 in production —
qualitative,scripts,notebooks,python_integration. My earlier check passed becausepython -m http.servergenerates directory listings and GitHub Pages does not: a folder only becomes a page if it holds aREADME.md, and those four do not. The tiles now link to GitHub, uniformly, which never 404s and is honest about their being R source rather than pages.The four that did resolve rendered with no styling at all, so clicking through left the design behind.
_layouts/default.htmland_config.ymlnow render any folder README in the house style, with the same top bar and type.The hero counted "37 Checks in CI". A reader does not care how many tests run. Replaced with the module count.
Type of change
Checklist
index.html. No broken internal linksCLAUDE.mdrecords the trapsCorrection
The previous PR claimed all 12 internal links resolved. They resolved against a local server that fabricates directory indexes. Four were broken in production from the moment it merged.
🤖 Generated with Claude Code
https://claude.ai/code/session_01DMYhECx2Dzbqad6KJxWZ7t
Generated by Claude Code