fix: an oversized first page no longer flushes an empty chunk - #477
Open
jerrl10 wants to merge 2 commits into
Open
fix: an oversized first page no longer flushes an empty chunk#477jerrl10 wants to merge 2 commits into
jerrl10 wants to merge 2 commits into
Conversation
current_subset is still empty on the first page, so a page over average_tokens_per_part flushed an empty chunk that both callers then passed to the model as a slice of the document.
jerrl10
force-pushed
the
fix/empty-first-chunk
branch
from
September 4, 2026 16:07
756addc to
780b2ed
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #467.
What
page_list_to_group_text()closed its accumulator whenever the running token count plus the next page exceededaverage_tokens_per_part. On the first page the accumulator is still empty and the count is zero, so the test reduced totoken_lengths[0] > average_tokens_per_partand appended an empty string as chunk 0.Both callers pass that chunk to the model as a slice of the document —
process_no_toc()seeds the entire table of contents from it, andprocess_toc_no_page_numbers()can raiseValueErrorand abort the run.