-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Client instructions: a standing persona for every answer surface #497
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
6 commits
Select commit
Hold shift + click to select a range
30f85df
Client instructions: a standing persona for every answer surface
rejojer c4df589
Managed fold: always send the canonical history
rejojer 3064d9d
Managed fold: lift system rows only, forward the rest verbatim
rejojer dfef3ab
Chat history: normalize the container, validate only what the SDK reads
rejojer 1eb74ec
fix: ctor type error names the answer, not a lane managed clients can…
rejojer 75f93e8
Rebase onto the merged lanes: two pins the lift and the targeting mov…
rejojer File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For a plain cloud client, the managed branch preserves every non-system message verbatim (including tool roles, structured content, and extra fields) and lets the endpoint reject unsupported input. Consequently, this public docstring incorrectly promises that tool turns are rejected by both engines and extra fields are dropped; callers can instead receive endpoint 400/422 errors and have extra fields transmitted. Qualify these guarantees as applying only to the own-model engine and describe the managed pass-through behavior.
Useful? React with 👍 / 👎.