feat: implement segment OR groups with ruleSets and conditions - #18
Open
sojitra-nency wants to merge 1 commit into
Open
sojitra-nency wants to merge 1 commit into
sojitra-nency wants to merge 1 commit into
Conversation
sojitra-nency
commented
Aug 19, 2026
sojitra-nency
commented
Contributor
- Added support for segment OR groups in the engine, allowing multiple ruleSets to be evaluated with an 'any' or 'all' match mode.
- Introduced a new segment schema that includes ruleSets and a match mode, ensuring backward compatibility with existing conditions.
- Updated the evaluation logic to prioritize ruleSets over conditions, ensuring correct behavior for segments with both.
- Created comprehensive tests for the new segment functionality, covering various scenarios including edge cases.
- Added a new fixture for segment OR groups to validate the implementation against expected outcomes.
- Added support for segment OR groups in the engine, allowing multiple ruleSets to be evaluated with an 'any' or 'all' match mode. - Introduced a new segment schema that includes ruleSets and a match mode, ensuring backward compatibility with existing conditions. - Updated the evaluation logic to prioritize ruleSets over conditions, ensuring correct behavior for segments with both. - Created comprehensive tests for the new segment functionality, covering various scenarios including edge cases. - Added a new fixture for segment OR groups to validate the implementation against expected outcomes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.