Repository navigation
Conversation
The D-114 flank shifted the staging cell perpendicular to the line toward the enemy. On the diagonal Glutrinne that moved it to Chebyshev 22 from the HQ, outside the staging ring at 16, so every unit on its way counted as committed and attacked alone: 91-222 attack orders per match before any wave was ready, against 0 without a flank. The flank now scales the offset back onto the staging distance, turning the cell around the HQ. The unflanked path and the neutral personality are unchanged. The Turtle home radius (10 + 4 = 14) reached past the staging cell and called the waiting wave home; Apply now caps what a personality adds one cell short of the staging distance (11 on the shipped profile). Also from the PR #144 review: the flank test now reads the real HQ cell and is checked against the cell the AI reports; a regression test pins "nothing committed, no attack before the first ready wave"; NOVA_MATCH_SEED warns on unparsable values and outside the menu; AiPersonality docstrings and the D-114 changelog text are corrected. AiBehaviorId moves to r10; no new D-ID, D-114 carries a correction. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Folge-PR zum Review von #144 (D-114, KI-Persönlichkeit). Behebt B1 und B2 und nimmt die kleineren Befunde B4 bis B7 mit.
Was und warum
GetStagingCellskaliert den Versatz jetzt aufStagingDistanceCellszurück. Der Punkt dreht sich also um das HQ, statt hinausgeschoben zu werden.Applydeckelt jetzt, was eine Persönlichkeit hinzufügt, aufStagingDistanceCells − 1, auf dem ausgelieferten Profil also 11.Applysieht beide.IAiGoalObservermeldet.FlankedWave_SendsNobodyBeforeTheFirstWaveIsReady: Vor der ersten fertigen Welle ist nichts committed und es gibt keinen Angriff, für beide Fraktionen und Flanke −10/0/+10.NOVA_MATCH_SEEDwarnt jetzt bei einem ungültigen Wert und außerhalb des Menüs.AiPersonalitysind berichtigt: Bit-Bereiche, 1728 Kombinationen,ToString-Beispiel.AiBehaviorIdsteigt auf r10, ohne neue D-ID (Inhaberentscheidung). D-114 trägt einen Absatz „Berichtigung (2026-10-17)“, das DecisionLog steht auf 1.46.1.Nur vermerkt, kein Code
feat/generals-look-and-feel.WithOfferden Seed überschreibt.Nachweise
dotnet test tools/Nova.SimRunner.Tests -c Release: 783/783 grün.CanonicalAiOutcomeTestsist unverändert und grün.check_docs.py: OK.Changelog
Neuer Eintrag unter
[Unreleased]→Behoben. Dazu Berichtigungen im D-114-Eintrag unterHinzugefügt.🤖 Generated with Claude Code