Repository navigation
Conversation
MapDefinitionSO was written by the bootstrap scene generator and read by nobody at runtime; the headless lane cannot read a ScriptableObject at all. That is why its content was silently wrong for a whole sprint (five fields while MatchBootstrap registered fifteen). Type, MapBiomeType, MAP_Glutrinne.asset, the EditMode test, the generator section and MatchBootstrap.CanonicalHqCentreCells (its only reader) go away, each with its .meta. GUID and symbol search found no remaining reference. More than one map returns, if at all, after G5 as an engine-free map definition with its own decision. Fixes #127. Decision D-123 (draft; binding with the merge). Sim tests 778/778; Unity compile, generator run and Data EditMode tests not run. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
EditMode 662/662 and PlayMode 15/15 measured on this branch with Unity 6000.5.4f1 via the lane script from #110; no failures, clean tree. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Was:
MapDefinitionSO,MapBiomeType,MAP_Glutrinne.asset, der EditMode-Test, der Generator-Abschnitt undMatchBootstrap.CanonicalHqCentreCells(einziger Leser) entfallen, jeweils mit.meta. GUID- und Symbolsuche: kein verbleibender Verweis.Warum: Kein Laufzeitleser; die Headless-Spur kann kein ScriptableObject lesen. Deshalb war der Inhalt einen Sprint lang unbemerkt falsch. Mehr als eine Karte kommt, wenn überhaupt, nach G5 als engine-freie Definition mit eigener D-ID. Fixes #127, Entscheidung D-123 (Entwurf, Variante 2).
Bereiche:
Scripts/Data/Maps,Data/Maps,Editor/BootstrapSceneGenerator,Gameplay/Match/MatchBootstrap, MapExpansion_Spec.md, ScopeLedger.md (0.8.0), DecisionLog, CHANGELOG.Changelog:
[Unreleased]→ Entschieden.Tests:
dotnet test778/778;check_docs.pyOK; Guard-Selbsttest OK.Unity-Spuren: EditMode 662/662, PlayMode 15/15; Logs ohne
error CS, ohne Treffer aufMapDefinition/Missing script.Spielabnahme: nicht gespielt — keine Spielverhaltensänderung.
Hinweis: Art-Commit 73f54b5 ändert
MatchBootstrap.csnahe der Stelle; laut Review kein Textkonflikt durch diesen PR.Berichte:
reports/v8.6.0/issue-lauf-2026-10-17/04-issue-127-*.md,04b-review-1-issue-127.md.🤖 Generated with Claude Code