Repository navigation
Rename review plumbing that also carries shred plans (M01-04d slice 2) - #50
Merged
Merged
Conversation
… slice 2) No behavior change. The review field and approval type kept Trash-specific names after M01-04c routed the Shredder through them: - TrashApproval -> ReviewApproval - the trashPlan field / labels on ReviewRequest and ConfirmedPreview -> cleanupPlan - SelfTest: confirmTrashReview -> confirmReview, trashApproval locals -> approval Kept on purpose: AppCleanup.trashPlan(...) builders (they only build Trash plans), EngineTrashItem, ApprovedTrash, trashMover, file names. No string literal, Codable key or MCP/CLI output changes. Docs updated.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
M01-04d slice 2: a pure rename, no behavior change. Since M01-04c the Shredder's
.overwriteThenDeleteplans travel through the same review plumbing as Trash plans, so the Trash-specific names were misleading.TrashApprovalReviewApproval(notCleanupApproval, which already exists in the package)trashPlanfield / init labels onReviewRequest,ConfirmedPreviewcleanupPlanconfirmTrashReview,trashApproval(SelfTest)confirmReview,approvalKept on purpose:
AppCleanup.trashPlan(...)builders (they only build Trash plans),EngineTrashItem,ApprovedTrash,trashMover, the.approved(ApprovedTrash)payload, all file names. No string literal, Codable key, log message or MCP/CLI output changes. The doc comment onReviewApprovalnow says what it carries. Docs:M01-04C_DESIGN.md,MIGRATION_PLAN.md.Safety
safety-touch.sh: SAFETY-CRITICAL yes (approval plumbing renamed). The user approved this change; Sonnet review only (no Opus, user's choice).check-approval-sites.shnames none of the renamed tokens, so no rule stopped matching.Checks (local)
check-approval-sites.sh: pass (fresh)check-no-test-hooks.sh: passmc-reviewer: approve, no blockers; its two doc findings and one comment nit are fixed🤖 Generated with Claude Code