Skip to content

Rename review plumbing that also carries shred plans (M01-04d slice 2) - #50

Merged
WahdanZ merged 1 commit into
mainfrom
m01-04d-2-review-rename
Nov 18, 2026
Merged

WahdanZ merged 1 commit into
mainfrom
m01-04d-2-review-rename

Conversation

@WahdanZ

@WahdanZ WahdanZ commented Nov 18, 2026

Copy link
Copy Markdown
Owner

What

M01-04d slice 2: a pure rename, no behavior change. Since M01-04c the Shredder's .overwriteThenDelete plans travel through the same review plumbing as Trash plans, so the Trash-specific names were misleading.

Before After
TrashApproval ReviewApproval (not CleanupApproval, which already exists in the package)
trashPlan field / init labels on ReviewRequest, ConfirmedPreview cleanupPlan
confirmTrashReview, trashApproval (SelfTest) confirmReview, approval

Kept on purpose: AppCleanup.trashPlan(...) builders (they only build Trash plans), EngineTrashItem, ApprovedTrash, trashMover, the .approved(ApprovedTrash) payload, all file names. No string literal, Codable key, log message or MCP/CLI output changes. The doc comment on ReviewApproval now says what it carries. Docs: M01-04C_DESIGN.md, MIGRATION_PLAN.md.

Safety

safety-touch.sh: SAFETY-CRITICAL yes (approval plumbing renamed). The user approved this change; Sonnet review only (no Opus, user's choice). check-approval-sites.sh names none of the renamed tokens, so no rule stopped matching.

Checks (local)

  • Build OK; warning budget OK (4, all baselined)
  • Package tests: 145 pass
  • check-approval-sites.sh: pass (fresh)
  • check-no-test-hooks.sh: pass
  • Self-test, Release app: 460 passed, 0 failed
  • Self-test, test-hooks app: 473 passed, 0 failed
  • mc-reviewer: approve, no blockers; its two doc findings and one comment nit are fixed

🤖 Generated with Claude Code

… slice 2)

No behavior change. The review field and approval type kept Trash-specific
names after M01-04c routed the Shredder through them:
- TrashApproval -> ReviewApproval
- the trashPlan field / labels on ReviewRequest and ConfirmedPreview -> cleanupPlan
- SelfTest: confirmTrashReview -> confirmReview, trashApproval locals -> approval

Kept on purpose: AppCleanup.trashPlan(...) builders (they only build Trash
plans), EngineTrashItem, ApprovedTrash, trashMover, file names. No string
literal, Codable key or MCP/CLI output changes. Docs updated.
@WahdanZ
WahdanZ merged commit 2f5b6f2 into main Nov 18, 2026
2 checks passed
@WahdanZ
WahdanZ deleted the m01-04d-2-review-rename branch November 18, 2026 11:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant