Repository navigation
Keep the legacy review fallback and pin confirm's routing (M01-04d slice 3) - #51
Merged
Merged
Conversation
…ice 3) No behavior change. ReviewConfirmation.confirm still calls perform when a review has no performApproved: junk/caches, build files, app cache and the Homebrew uninstall review use it until their modules move to the executor (M01-06...). Documented on ReviewConfirmation and ReviewRequest.perform. Self-test (17 checks): a legacy review runs perform once with exactly the allowed ids; an approved review never calls perform; all nine approved builders, built from real sandbox inputs, set performApproved with their cleanup plan; junk, appCache and projects are pinned as legacy.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
M01-04d slice 3: audit of the legacy
performfallback inReviewConfirmation.confirm. No behavior change (docs + self-test only; the user approved this scope as safety-critical "docs + tests").Finding: the fallback is still reachable, so it stays. A review without
performApprovedis confirmed by callingperformwith the allowed ids. Four production reviews use it because their modules aren't on the executor yet (M01-06…):ContentView.swift:581→ReviewBuild.junkProjectsView.swift:90→ReviewBuild.projectsAppsView.swift:221→ReviewBuild.appCacheAppsView.swift:182(inlineReviewRequest)Changes
ReviewConfirmation.swift,Review.swift: doc comments only (why the fallback stays; approved builders pass a no-opperform; a review with acleanupPlanmust setperformApproved).SelfTest.swift(+17 checks): legacy routing (perform once, exact allowed ids, blocked excluded); approved routing with and without a plan (perform never called); all nine approved builders built from real sandbox inputs have a plan andperformApproved; junk, appCache, projects pinned as legacy. The inline Homebrew review is not covered (documented).MIGRATION_PLAN.md,CURRENT_STATE.md: wording.Checks (local)
check-approval-sites.shpass;check-no-test-hooks.shpassmc-reviewer: approve; both should-fix items (vacuous builder checks, overstated docs) and the nits fixed🤖 Generated with Claude Code