Skip to content

Keep the legacy review fallback and pin confirm's routing (M01-04d slice 3) - #51

Merged
WahdanZ merged 1 commit into
mainfrom
m01-04d-3-perform-fallback
Nov 18, 2026
Merged

WahdanZ merged 1 commit into
mainfrom
m01-04d-3-perform-fallback

Conversation

@WahdanZ

@WahdanZ WahdanZ commented Nov 18, 2026

Copy link
Copy Markdown
Owner

What

M01-04d slice 3: audit of the legacy perform fallback in ReviewConfirmation.confirm. No behavior change (docs + self-test only; the user approved this scope as safety-critical "docs + tests").

Finding: the fallback is still reachable, so it stays. A review without performApproved is confirmed by calling perform with the allowed ids. Four production reviews use it because their modules aren't on the executor yet (M01-06…):

Review Entry
Junk / caches ContentView.swift:581 → ReviewBuild.junk
Build files ProjectsView.swift:90 → ReviewBuild.projects
App cache AppsView.swift:221 → ReviewBuild.appCache
Homebrew uninstall AppsView.swift:182 (inline ReviewRequest)

Changes

  • ReviewConfirmation.swift, Review.swift: doc comments only (why the fallback stays; approved builders pass a no-op perform; a review with a cleanupPlan must set performApproved).
  • SelfTest.swift (+17 checks): legacy routing (perform once, exact allowed ids, blocked excluded); approved routing with and without a plan (perform never called); all nine approved builders built from real sandbox inputs have a plan and performApproved; junk, appCache, projects pinned as legacy. The inline Homebrew review is not covered (documented).
  • MIGRATION_PLAN.md, CURRENT_STATE.md: wording.

Checks (local)

  • Build OK; warning budget OK (4, all baselined)
  • check-approval-sites.sh pass; check-no-test-hooks.sh pass
  • Self-test (fresh): 477 passed, 0 failed, every new check present in the log
  • Package tests: unchanged files (145 pass on the previous run)
  • mc-reviewer: approve; both should-fix items (vacuous builder checks, overstated docs) and the nits fixed

🤖 Generated with Claude Code

…ice 3)

No behavior change. ReviewConfirmation.confirm still calls perform when a
review has no performApproved: junk/caches, build files, app cache and the
Homebrew uninstall review use it until their modules move to the executor
(M01-06...). Documented on ReviewConfirmation and ReviewRequest.perform.

Self-test (17 checks): a legacy review runs perform once with exactly the
allowed ids; an approved review never calls perform; all nine approved
builders, built from real sandbox inputs, set performApproved with their
cleanup plan; junk, appCache and projects are pinned as legacy.
@WahdanZ
WahdanZ merged commit 3765096 into main Nov 18, 2026
2 checks passed
@WahdanZ
WahdanZ deleted the m01-04d-3-perform-fallback branch November 18, 2026 12:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant