Repository navigation
Conversation
…e 4, PR 2) Removes bridge 2 (the semaphore in ToolConfirmation.approveTrash). No change to MCP JSON, CLI output, exit codes, refusal texts or the approval order. - approveTrash and ToolConfirmation.moveToTrash are async; ApprovalSlot, Task.detached and the semaphore are gone. move_to_trash awaits AppCleanup.moveToTrash directly (the engines keep their bridge until PR 3). - MCPServer.call/handle and CLI.run are async. The single stdin consumer awaits handle before taking the next line, so requests still run one at a time in order; the person's dialog stays synchronous on the main actor. - uninstall_app keeps approve -> quit check -> approveTrash -> engine. - --cli bench runs Bench through CLI.bench on its own sync path. - Self-test: MCP calls go through wait; a timeout records a failed check. - D-018 and the run() comment state the updated invariant. Negative control: approving before the quit check fails the PR 0 'no executor approval issued' check.
…n inheritance - A timed-out MCP call keeps running and could act during later checks, so the self-test now stops (exit 1) after recording the failed check. - D-018: the executor's cancellation check now sees the caller's task (never cancelled today); a future cancel stops between items.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
PR 2 of M01-04d slice 4 (0 ✅ → 1a ✅ → 1b ✅ → 2 → 3 → 4). Removes bridge 2 (the semaphore in
ToolConfirmation.approveTrash). No change to MCP JSON, CLI output, exit codes, refusal texts or the approval order. User approval: SAFETY-CRITICAL APPROVED for exactly this scope.approveTrashandToolConfirmation.moveToTrashareasync;ApprovalSlot,Task.detachedand the semaphore are gone.move_to_trashawaitsAppCleanup.moveToTrashdirectly. The engines (AppEngine.uninstall,SDKEngine.remove,SystemDataEngine.remove) still take a ready approval and keep bridge 1 until PR 3.MCPServer.call/handleandCLI.runareasync. The single stdin consumer awaitshandlebefore taking the next line, so requests still run one at a time, in order; the person's dialog stays synchronous on the main actor.uninstall_app:approve→ quit check →await approveTrash→ engine (unchanged order).ConfirmedPreview: Sendable.--cli benchruns throughCLI.benchon its own sync path (never inside the main loop);CLI.run's unreachablebenchcase fails closed (64), likemcp.wait; a timeout records a failed check.run()comment state the updated invariant.Proof
Checks (local)
check-approval-sites.shpass;check-no-test-hooks.shpassbenchand--cli mcpBefore merge
mc-reviewerandmc-safety-architect(Opus) clean🤖 Generated with Claude Code