Repository navigation
Keep per-instance where an include is, and refuse runs that cannot pick an instance - #118
Merged
Merged
Conversation
…ck an instance An included file is per instance only at the sites an instance's value reaches: the mark is kept per place (node and include path), and every reader (engine, run refusals, activation, infra, displays, rules, the editor's view of an included file) asks it of a place. A shared trigger whose runs would reach something per instance is refused by the compiler, at that site only (broken parts now name their places); routes and sockets stay exempt since each call names its instance. Also: - a loop with no outputs ends (its LoopOut starts with each iteration); a loop output nothing inside writes is refused (loop-output-unwritten) - a file stored for its run only and wired into a node that keeps its inputs past the run is warned about (run-file-kept-past-run), from two new metadata keys, fileScopeFrom and keepsInputsPastRun - tags work on unrecorded runs - a value checked against a record names every missing, unknown and wrong field at once, casts label each problem, unknown keys are capped and escaped, and union probing stops at the first problem - docs, Tangle copies and the changelog follow
# Conflicts: # CHANGELOG.md
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What changes
A file included in two places is now per instance only where an instance's value reaches it. A program that includes one helper file from a shared route and from a group holding a per-instance part (a bridge per customer) had every shared run refused (
... exists once per instance, so this run needs to know which instance it is for). Now each include decides for itself.shared-trigger-reaches-per-instance). It names what the trigger reaches and why each part is per instance. Before, every fire was refused at run time.loop-output-unwritten).parallel: falseguarantees, and that an iteration can outlive its loop.scope: runand wired into a node that keeps its inputs past the run gets a warning (run-file-kept-past-run). Two new metadata keys drive it:fileScopeFromandkeepsInputsPastRun.TagRunandStopTaggedwork on a run whose trigger hasrecorded: false.What breaks
weft resyncafter updating.The CHANGELOG entry is
2026-11-01 (0.2.283).Checked locally
Everything the PR's checks run, on this branch's final code:
-D warnings, the parse-only build, validate-examples, hakari, terraform validate and the moved-targets test;setup.shand the named e2e tests (the include outage shape, an outputless loop, a typed route body).