Allow struct.wait on equality-comparable fields except floats - #8939
Open
stevenfontanella wants to merge 7 commits into
Open
Allow struct.wait on equality-comparable fields except floats#8939stevenfontanella wants to merge 7 commits into
stevenfontanella wants to merge 7 commits into
Conversation
stevenfontanella
force-pushed
the
waitqueue-eq
branch
2 times, most recently
from
July 28, 2026 20:26
12a3523 to
ff41b36
Compare
stevenfontanella
force-pushed
the
waitqueue-eq
branch
from
August 11, 2026 22:10
5a4d346 to
01fd17a
Compare
stevenfontanella
changed the title
stevenfontanella
force-pushed
the
waitqueue-eq
branch
5 times, most recently
from
August 14, 2026 19:20
bc727ff to
41cfd56
Compare
stevenfontanella
marked this pull request as ready for review
August 14, 2026 20:06
kripken
reviewed
Aug 14, 2026
stevenfontanella
force-pushed
the
waitqueue-eq
branch
from
August 18, 2026 17:56
e7f2a7d to
ca0f641
Compare
Member
Author
|
Looks like my merge did something weird. I'll just rebase onto the latest main. Apologies for the force-push. |
stevenfontanella
force-pushed
the
waitqueue-eq
branch
from
August 20, 2026 15:46
6001030 to
853b2cc
Compare
kripken
reviewed
Aug 20, 2026
| return; | ||
| } | ||
| const auto& fields = curr->ref->type.getHeapType().getStruct().fields; | ||
| if (curr->index < fields.size()) { |
Member
There was a problem hiding this comment.
Do we need this check - seems like the same issue, or am I not seeing the reason?
Member
Author
There was a problem hiding this comment.
You're right, this is from an earlier iteration that I missed. Removed it now.
kripken
reviewed
Aug 20, 2026
| void FunctionValidator::visitStructWait(StructWait* curr) { | ||
| // In IRBuilder, we check that the struct ref matches the type immediate. | ||
| // We can't check this here because we've already discarded the type immediate | ||
| // at this point. All other validations are here. |
Member
There was a problem hiding this comment.
This is a general comment, not specific to StructWait - let's remove it?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #8315. #8672 added struct.wait for i32 struct fields, but left out support for i64 and subtypes of
ref null (shared eq). See the details in the proposal.