Docs: add v1.7.2.4.1 roadmap entry, fix stale lock-file limitation - #13
Merged
Merged
Conversation
… lock-file limitation New ROADMAP.md entry for v1.7.2.4.1 (planned) — self-updater startup handshake + auto-rollback via _update_backup/, replacing today's silent-failure behavior in updater_helper.ps1's GUI-triggered path. Handshake shape (app writes a success flag once up and interactive, helper polls with a generous timeout) chosen over a plain PID-liveness timeout after review: a bare timeout races against first-launch AV scanning and doesn't distinguish 'alive' from 'actually started correctly'. Entry documents an open design point (the existing migration confirmation dialog must not gate the flag, or a user who hasn't clicked yet triggers a false rollback) and a correctly-scoped data-safety caveat (mcp_cache.db is an additive-only, rebuildable proxy cache outside ExeDir — the real analogous risk is the archive structure migration behind _check_migration(), already interactive/ opt-in, out of scope for this round). Placed directly after 'Currently stable — v1.7.2.4', ahead of v1.7.2.5/v1.7.2.6 — it is a patch on v1.7.2.4, not a successor to v1.7.2.6, so version order puts it first regardless of write order. Also fixes a stale-docs inconsistency found during the same review: CHANGELOG.md's v1.7.2.4 'Known limitations' and ROADMAP.md both still claimed no lock file existed against concurrent update triggers, but updater_helper.ps1 already has one (_update_helper.lock), added within that same v1.7.2.4 commit. Removed both stale mentions. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_011Z4cpStY3EYYqyd1CLsGhJ
|
Navigate logical layers of code changes, visualize relationships, and explore their blast radius. Note Currently processing new changes in this PR. This may take a few minutes, please wait... ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (2)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
… lock-file limitation
New ROADMAP.md entry for v1.7.2.4.1 (planned) — self-updater startup handshake + auto-rollback via _update_backup/, replacing today's silent-failure behavior in updater_helper.ps1's GUI-triggered path. Handshake shape (app writes a success flag once up and interactive, helper polls with a generous timeout) chosen over a plain PID-liveness timeout after review: a bare timeout races against first-launch AV scanning and doesn't distinguish 'alive' from 'actually started correctly'. Entry documents an open design point (the existing migration confirmation dialog must not gate the flag, or a user who hasn't clicked yet triggers a false rollback) and a correctly-scoped data-safety caveat (mcp_cache.db is an additive-only, rebuildable proxy cache outside ExeDir — the real analogous risk is the archive structure migration behind _check_migration(), already interactive/ opt-in, out of scope for this round).
Placed directly after 'Currently stable — v1.7.2.4', ahead of v1.7.2.5/v1.7.2.6 — it is a patch on v1.7.2.4, not a successor to v1.7.2.6, so version order puts it first regardless of write order.
Also fixes a stale-docs inconsistency found during the same review: CHANGELOG.md's v1.7.2.4 'Known limitations' and ROADMAP.md both still claimed no lock file existed against concurrent update triggers, but updater_helper.ps1 already has one (_update_helper.lock), added within that same v1.7.2.4 commit. Removed both stale mentions.
Claude-Session: https://claude.ai/code/session_011Z4cpStY3EYYqyd1CLsGhJ