Repository navigation
v0.4.0.1: restore Vietnamese translations, fix daisyUI modals under Unfold - #23
Merged
Merged
Conversation
… Unfold
- i18n: _() calls inside f-strings are invisible to makemessages, so
regenerating the catalog for 0.4.0.0 made 8 strings obsolete and they
showed in English (user badges Inactive/Admin/Bot, 'has been updated
by user' in every update notification, M2M added/removed, dashboard
'progress from last'/'in'). Calls moved out of the f-strings,
translations restored; dashboard KPI uses whole sentences with named
placeholders, 'day'/'successful' and notification bodies ('with the
following changes') are translated; +0 instead of a red -0; literal
color classes.
- Modals: Unfold's unlayered dialog{} rule beats daisyUI's layered
.ui-modal, so an open ui-modal was a narrow white column with no
overlay (announcement, feedback resolve, markdown preview).
dialog.ui-modal restores the full-screen modal. It is the only
unlayered Unfold rule on a bare element.
- /announcement/: empty content (and a warning) instead of a 500 when
the project template is missing or the setting is empty.
- Tests: no gettext inside f-strings; every literal msgid in Python code
is in the compiled vi catalog; KPI translated; modal CSS override;
announcement endpoint. All fail on 0.4.0.0.
- Version 0.4.0.1, CHANGELOG / README / release notes.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Patch release for the issues the dev team reported against v0.4.0.0, plus everything of the same kind found by a systematic sweep.
1. Translations dropped in 0.4.0.0
makemessagescan't read_()inside f-strings. When the catalog was regenerated for 0.4.0.0, the strings used only that way became obsolete (#~), were left out ofdjango.mo, and showed in English. The report named two of them; the sweep found eight:How the sweep worked:
The fix:
_()calls are moved out of the f-strings and the translations restored bymsgmerge.%(object)s in %(period)s→ "Hoạt động trong tuần", and%(count)s successful (%(rate)s%%).2.
ui-modaloverridden by Unfold'sdialogruleUnfold styles every
<dialog>with an unlayered rule (width: container-md,translate: -50% -50%, white background, padding). Unlayered CSS beats daisyUI's layered.ui-modalregardless of specificity. As a result, an open modal was a 448px white column with no overlay: the announcement dialog, the feedback "resolve" dialogs and the markdown preview.The fix:
dialog.ui-modalrule restores the full-screen modal and its dimmed overlay, and drops Unfold's blurred::backdrop.dialogis the only one on a bare element. The others are scoped to Unfold's own widgets (calendar, jsoneditor, selector), and none touches the daisyUI components the package uses.3.
/announcement/returned a 500ANNOUNCEMENT_CONTENT_HTML_FILEtemplate is missing.Nonewhen the setting is empty.Version
0.4.0.1, with CHANGELOG / README entries anddocs/reports/releases/2026-10-14-v0.4.0.1.md. No migrations.Tests
New tests, each failing on v0.4.0.0:
makemessagesdrops);styles.csscarries thedialog.ui-modaloverride;/announcement/without a template and with an empty setting.Validation
checkis clean andmakemigrations --checkreports no changes.msgfmt --checkpasses; no untranslated or fuzzy entries..moleave no diff.After merge
Create a GitHub Release
v0.4.0.1onmain2.0. PyPI and the Docker base images (v0.4.0.1) are published by the workflows.