Skip to content

test(structural): add parser failure golden fixture - #43

Merged
nia-sg-bot merged 1 commit into
mainfrom
nia/issue-22-syntax-failure-fixture
Sep 1, 2026
Merged

test(structural): add parser failure golden fixture#43
nia-sg-bot merged 1 commit into
mainfrom
nia/issue-22-syntax-failure-fixture

Conversation

@nia-sg-bot

@nia-sg-bot nia-sg-bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Summary

  • add a checked-in golden fixture for a Python Tree-sitter syntax failure
  • assert the emitted artifact keeps the file provenance while producing no symbols or relationships
  • lock the warning code, scope, and deterministic parser failure detail

Part of #22.

Validation

  • python3 -m pytest (150 passed)
  • git diff --check

Remaining work

Other #22 acceptance slices, including additional deterministic topology coverage, remain tracked by the parent issue.

Summary by CodeRabbit

  • Tests
    • Added coverage for Python parsing failures using a golden fixture.
    • Verified that failed files are reported accurately without inventing symbol or relationship changes.
    • Confirmed parse-failure warnings and analysis metadata are captured consistently.

@nia-sg-bot nia-sg-bot added roadmap Tracked on the public WildestAI roadmap priority:P0 Critical path / blocks a usable product direction:aligned Aligned with the current WildestAI product direction labels Sep 1, 2026
@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor

Review Change Stack

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Team

Run ID: 9e934092-7321-43f4-a391-e88c36408e08

📥 Commits

Reviewing files that changed from the base of the PR and between ac1cfe9 and ea4c1c0.

📒 Files selected for processing (2)
  • tests/fixtures/python_parser_failure.json
  • tests/test_structural.py

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.


Walkthrough

The PR adds a golden fixture for a Python parse failure and updates the structural test to compare the generated artifact with that fixture.

Changes

Parse failure validation

Layer / File(s) Summary
Golden fixture comparison
tests/fixtures/python_parser_failure.json, tests/test_structural.py
The fixture defines the expected modified file, empty symbols and relationships, skipped-file metadata, and PARSE_FAILURE warning. The structural test compares the generated artifact with these values.

Estimated code review effort: 2 (Simple) | ~10 minutes

Merge Risk: ⚪ Minimal · up to ea4c1

This change only strengthens regression coverage for parser-failure output without changing production behavior, so no actionable merge-blocking risk remains beyond normal checks and review.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1… Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly and concisely describes the main change: adding a golden fixture for a structural parser failure test.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

Docstring coverage is 33.33% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 3 functions across 1 files. (1 skipped: 1 unsupported.)

  • Fix all pre-merge checks with AI
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch nia/issue-22-syntax-failure-fixture

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@nia-sg-bot

Copy link
Copy Markdown
Contributor Author

@coderabbitai review

@coderabbitai

coderabbitai Bot commented Sep 1, 2026

Copy link
Copy Markdown
Contributor
✅ Action performed

Review finished.

Note: CodeRabbit is an incremental review system and does not re-review already reviewed commits. This command is applicable only when automatic reviews are paused.

@nia-sg-bot
nia-sg-bot merged commit c067289 into main Sep 1, 2026
4 checks passed
@nia-sg-bot
nia-sg-bot deleted the nia/issue-22-syntax-failure-fixture branch September 1, 2026 20:02
@nia-sg-bot
nia-sg-bot restored the nia/issue-22-syntax-failure-fixture branch September 3, 2026 03:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

direction:aligned Aligned with the current WildestAI product direction priority:P0 Critical path / blocks a usable product roadmap Tracked on the public WildestAI roadmap

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant