Repository navigation
fix: expose complete Java text block escapes - #40
Merged
Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <agent@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Text-block line continuations and zero-octal escapes can disappear from the public tree, so the shipped escape query cannot highlight them. Escaped quotes after raw quote fragments are also hidden. Reusing the public escape token alone still splits a CRLF continuation after CR.
Requirements
Customer Summary
Text-block continuations, zero-octal escapes and escaped quotes are visible as complete
escape_sequencenodes and receive the shipped escape highlight, including CRLF continuations.Technical Summary
grammar.jsusesescape_sequencedirectly in text blocks, recognizes CRLF as one escape token and keeps escaped quotes out of quoted fragments. The public node schema is unchanged. The existing literal corpus gains its missing escape node; three API regressions check complete nodes, highlight spans and following declarations across LF, CRLF and CR.Testing
bun run verifypassed with zero code-gauge violations. Rust unit and documentation tests passed. All 165 corpus cases passed 100 fuzz iterations with ten edits, explicitly using seed 1.Notes
The additional CRLF and quoted-fragment changes cover compiler-valid escape spans that the upstream visibility patch alone misses. Verification is scoped to the recorded cases rather than a claim of universal grammar equivalence.