Repository navigation
feat: expose typed parameter names as fields - #34
Merged
Merged
Conversation
Co-authored-by: WillBooster (Codex CLI) <codex@willbooster.com>
Co-authored-by: WillBooster (Codex CLI) <codex@willbooster.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
Typed parameters lack the
namefield that defaulted parameters expose, forcing consumers to infer which child represents the name. This addresses the typed-parameter inconsistency reported intree-sitter/tree-sitter-python#199.Requirements
namefield, matching the pattern-valued names already supported by default parameters without changing parameter node kinds.Customer Summary
Queries can select ordinary, variadic positional, and variadic keyword typed parameter names directly through
typed_parameter name:.Technical Summary
Add a field to the existing typed-parameter alternatives and regenerate the parser and node metadata. Splat names point to their existing pattern nodes. Update corpus field expectations and test querying real parsed declarations through the published WASM API.
Testing
bun run verifypassed; code-gauge reports no violations in changed code.bun wb test test/unit/typedParameterNames.test.ts test/unit/corpus.test.tspassed, including all 207 corpus cases.typed_parameter name:is invalid.