Move version checks to run as early as possible - #1088
Merged
Merged
Conversation
3 tasks done
3 tasks done
WillCodeForCats
added a commit
that referenced
this pull request
Sep 17, 2026
Only used in diagnostics, so we don't need these anymore after PR #1088
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Move version checks to run as early as possible in the init file instead of hub.
This way we can try to catch missing installs or old versions of our requirements (modbus-connection and tmodbus) instead of something else raising an exception later. Raising ConfigEntryError to HA with a message we can define is more user friendly, and can offer suggestions how to fix.
Also added checks for if it's not installed at all (possibly due to a network error when HA tries to satisfy requirements).