fix: use applicationId as React key for application cards (#759) - #793
Open
wilsonadenuga wants to merge 1 commit into
Open
wilsonadenuga wants to merge 1 commit into
wilsonadenuga wants to merge 1 commit into
Conversation
wilsonadenuga
requested review from
OlenaReukova,
Sowmiya07,
Tooonia,
dricazenck,
lauracabtay,
nora-weisser and
nverbic
September 20, 2026 21:53
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Application cards were keyed by
menteeId, so a mentee with several applications in a cycleproduced duplicate React keys. They now use the unique
applicationId, which the API alreadyreturns but
MenteeApplicationItemdidn't declare.Related Issue
Closes #759
Change Type
Screenshots
Before — two applications from the same mentee, duplicate key warning:
After — same list, no warning:
Pull request checklist
Please check if your PR fulfills the following requirements: