fix(samples): pin vite 7 and open CodeSandbox on the sample branch - #138
Merged
Conversation
![claude[bot]](https://avatars.githubusercontent.com/in/1236702?s=60&v=4){kind=small}
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
gaelsimon
force-pushed
the
fix/codesandbox-node
branch
from
September 3, 2026 07:21
5336346 to
ed47900
Compare
gaelsimon
changed the title
cmillett
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Samples never start in CodeSandbox: Vite 8 pulls rolldown, and the sandbox's default Node sits below the
enginesfloor Vite declares, so the native binding is skipped silently andvitedies on startup. Pinning back to the rollup line fixes it without a devcontainer, which would make every sandbox rebuild an image before booting.Second, separate bug in the same flow: the link pointed at
master/dist/..., where.envis gitignored, so samples opened without an API key. It now opens the per-sample branch, where.envis committed.Test: open a sample from the menu — it should boot on the default image, with its key.