fix(samples): make the vite config ESM so it loads on the sandbox Node - #139
Merged
Conversation
There was a problem hiding this comment.
Claude Code Review
This repository is configured for manual code reviews. Comment @claude review for a one-time review, or @claude review always to subscribe this PR to a review on every future push.
Tip: disable this comment in your organization's Code Review settings.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
With Vite pinned back to 7, samples still died in CodeSandbox:
vite.config.jsis ESM but the sample has no"type": "module", so Node treats it as CommonJS and tries torequire()Vite's ESM entry. That only works from Node 20.19, and the sandbox runs 20.12.1 — henceERR_REQUIRE_ESM.Generating
vite.config.mjsinstead makes Node load it as ESM natively, on any version. Theoxcblock goes with it: it was added for Vite 8 and is inert on 7 — the React samples still transform through esbuild, verified in the rebuilt bundles.Test:
vite buildandvite devboth pass under Node 20.12.1; the sandbox now only prints the version warning.