Abilities API: Make the ability category optional - #13157
Conversation
Test using WordPress PlaygroundThe changes in this pull request can previewed and tested using a WordPress Playground instance. WordPress Playground is an experimental project that creates a full WordPress instance entirely within the browser. Some things to be aware of
For more details about these limitations and more, check out the Limitations page in the WordPress Playground documentation. |
|
The following accounts have interacted with this PR and/or linked issues. I will continue to update these lists as activity occurs. You can also manually ask me to refresh this list by adding the Core Committers: Use this line as a base for the props when committing in SVN: To understand the WordPress project's expectations around crediting contributors, please review the Contributor Attribution page in the Core Handbook. |
This makes the
categoryargument optional when registering an ability. When it is omitted, the registry assigns the built-inuncategorizedcategory.Previously, the registry only validated a category when one was provided, but
WP_Abilitystill required the argument during instantiation. This left registrations without a category unable to succeed. Applying the fallback before validation keeps explicit invalid category values rejected while allowing simple or transitional registrations to omit a category.The change:
uncategorizedcategory with the other core ability categories;uncategorized;stringtype declaration to reject invalid types;Props @Sachin7907 for the patch and @itzmekhokan for feedback.
Trac ticket: https://core.trac.wordpress.org/ticket/65569
Testing
git diff --checkpasses.wpAbilitiesRegistry.php: 37 tests, 71 assertions.wpRegisterAbility.php: 20 tests, 50 assertions.wpRegisterCoreAbilities.php: 14 tests, 131 assertions.Use of AI Tools
AI assistance: Yes
Tool(s): OpenAI Codex
Model(s): GPT-5
Used for: Reviewing the existing local diff, running validation, and preparing the commits and pull request description. The implementation was reviewed by the submitter.
This Pull Request is for code review only. Please keep all other discussion in the Trac ticket. Do not merge this Pull Request. See GitHub Pull Requests for Code Review in the Core Handbook for more details.