Skip to content

fix:planner time off strip pattern not visible in light mode - #936

Merged
chamikaJ merged 2 commits into
developmentfrom
929-bug-planner-time-off-stripe-pattern-not-visible-in-light-mode
Nov 13, 2026
Merged

chamikaJ merged 2 commits into
developmentfrom
929-bug-planner-time-off-stripe-pattern-not-visible-in-light-mode

Conversation

@123sewmini

@123sewmini 123sewmini commented Nov 12, 2026 •

Copy link
Copy Markdown
Collaborator

Summary by CodeRabbit

  • Style
    • Updated full-day time-off stripes in schedule and workload views for improved visibility in light mode. Dark mode retains its existing stripe appearance.
    • Light-mode stripes now use a more visible amber color with a lighter alternating band in the schedule view, and a more opaque amber color in the workload view.

@123sewmini
123sewmini requested a review from chamikaJ as a code owner November 12, 2026 04:43
@coderabbitai

coderabbitai Bot commented Nov 12, 2026 •

Copy link
Copy Markdown
Contributor

Explain Change →

No actionable comments were generated in the recent review.

Walkthrough

The Schedule and Workload views now use updated amber stripe colors for full-day time-off cells. The Workload view also has JSX indentation changes; its existing content and behavior remain unchanged.

Changes: Planner presentation

Layer / File(s) Summary
Update full-day time-off stripes
worklenz-frontend/src/features/schedule/PlannerScheduleView.tsx, worklenz-frontend/src/features/schedule/PlannerWorkloadView.tsx
Both views use theme-specific stripe colors for full-day time-off cells. Dark mode retains the existing stripe. In the Workload view, light mode uses a more opaque amber stripe. Other changed JSX only has indentation adjustments; its content and behavior are unchanged.

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Bug fix

Merge Risk: Minimal · up to 651d0

This updates the time-off stripe colors in light mode so they are easier to see in the Schedule and Workload views. The change is presentational only, and no merge-blocking risk is evident.

Pre-merge checks: Passed 4

Check name Status Explanation
Description Check Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check Passed The title says the planner time-off stripe pattern was not visible in light mode. The raw summary says the PR makes the full-day time-off cell stripe more visible in light mode in PlannerScheduleView.…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Title check

Explanation

The title says the planner time-off stripe pattern was not visible in light mode. The raw summary says the PR makes the full-day time-off cell stripe more visible in light mode in PlannerScheduleView.tsx and PlannerWorkloadView.tsx. The title matches the main change and the linked objective (issue 929). The title is short, specific, and uses the 'fix:' prefix. The title follows the conventional style and names the affected view and mode.

Finishing Touches

Generate unit tests (beta)

  • Commit to this branch
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

Recent review info

Run configuration

Commits

Reviewing files that changed from the base of the PR and between 487a223 and 651d0e4.

Files selected for processing: 2

  • worklenz-frontend/src/features/schedule/PlannerScheduleView.tsx
  • worklenz-frontend/src/features/schedule/PlannerWorkloadView.tsx
Files skipped from review as they are similar to previous changes: 2

  • worklenz-frontend/src/features/schedule/PlannerScheduleView.tsx
  • worklenz-frontend/src/features/schedule/PlannerWorkloadView.tsx

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

…rn-not-visible-in-light-mode and clean up redundant time-off checks

@chamikaJ chamikaJ left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Resolved merge conflict with development and fixed the time-off stripe pattern in light mode across PlannerScheduleView and PlannerWorkloadView.

@chamikaJ
chamikaJ merged commit e8a4773 into development Nov 13, 2026
11 checks passed
@chamikaJ
chamikaJ deleted the 929-bug-planner-time-off-stripe-pattern-not-visible-in-light-mode branch November 13, 2026 10:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants