Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Upgrade the branch from Lean 4.29.0-rc8 to Lean 4.34.1, with matching mathlib and doc-gen4 revisions. Pin the migrated polynomial and Gröbner dependencies to published commits so this branch can build before their PRs are merged:
Adapt the renamed Gröbner-basis theorem and proof elaboration changes, remove an obsolete internal Lean import, and fix the out-of-scope set reference in
submodule_span. Scope the legacy transparency behavior to tactic execution so callers can usegb_solvewith default Lean options. Update the proof templates and remove two proof steps thatsimpnow discharges. Give one rational-coefficient remainder example a local heartbeat budget of 800000 after verifying that its default-budget kernel timeout is resolved. No newsorryor axioms.Validation:
lake build GroebnerTac GroebnerTac.Lemmaandlake build GroebnerTac.Templatelake build groebner/Groebnerlake build doc-gen4/doc-gen4using the native C compilersorryAx.lake build GroebnerTac GroebnerTac.Example GroebnerTac.Template GroebnerTac.Lemmaagainst the original source. All modules and examples passed except the explicit remote Sage API example atExample.lean:31, which failed because the external service's HTTPS connection ended withSSL: UNEXPECTED_EOF_WHILE_READING. The same mathematical example with local Sage is also present in the file and passed. No kernel timeouts remained.GroebnerTac/Cyclic3.leanis intentionally excluded, as requested, and remains untouched and untracked.