Repository navigation
Conversation
BattleSpawnFloatingIconAt and BattleSpawnFloatingIconAtPart are called from the Cho-Kyu and Kakusan magic overlays (by address); dropping static and declaring them in battle.h lets those overlays use a header prototype instead of a local one. No code change.
Names from the label walker's table (labels-quest/NAMES-bundles.tsv, sure rows only); renames only.
Names from the label walker's table (labels-quest/NAMES-bundles.tsv, sure rows only); renames only.
Cites functions that exist on origin/main (or in this PR); comments that named draft-only functions are repointed or dropped.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two spell overlays, imported and fully decompiled, no assembly left. One commit per overlay, then the names.
Stacked on #313: both overlays call BattleSpawnFloatingIconAt / BattleSpawnFloatingIconAtPart from battle2.c, so this includes that commit until #313 is in. No other shared file is changed.
Each file opens with the attack it belongs to, in the form the other magic files use; an effect several attacks share lists them. Functions are named
<Overlay><Thing><Verb>after what they draw or do (the sprite frames were decoded from each overlay to check the words); data keeps itsD_names. No shared header is changed.