Repository navigation
Prepare 26.11.5 with connection checks and Linux packages - #279
Merged
Merged
Conversation
added 7 commits
November 14, 2026 15:24
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
🔵 Needs a closer look
Reported fixture checks do not establish real-device VPN/probe isolation or full Linux and Arch ARM64 package compatibility, leaving critical platform validation unresolved.
No open issues 🎉
What changed in this PR
Prepares OneXray 26.11.5 with improved connection feedback, Smart routing reset controls, platform-specific update navigation, and expanded Linux packaging.
Changes:
- Adds draft-only Smart routing defaults restoration and a one-time, advisory node probe after connecting.
- Routes update actions to platform stores or GitHub Releases and adds RPM/pacman packaging with release checks.
- Adds regression coverage, documents behavior and validation requirements, and simplifies three READMEs.
| File | Description |
|---|---|
test/service/settings/app_update/service_test.dart |
Tests update destinations, fallback URLs, and launch failures. |
test/service/connect/startup_probe_test.dart |
Tests probe chains, outcomes, and skipped configurations. |
test/service/connect/startup_probe_coordinator_test.dart |
Tests probe scheduling, session identity, and lifecycle handling. |
test/service/connect/routing/smart/editor_test.dart |
Tests confirmation before saving defaults and reconnecting. |
test/pages/shared/connection_probe_notice_test.dart |
Tests one-time advisory notices and stale-result suppression. |
test/pages/connect/routing/smart/restore_defaults_test.dart |
Tests draft reset, form refresh, persistence, and pending selections. |
readme/README.zh_CN.md |
Simplifies the Chinese README and links detailed guides. |
readme/README.ru.md |
Simplifies the Russian README and links detailed guides. |
README.md |
Simplifies the English README and links detailed guides. |
pubspec.yaml |
Bumps the app version to 26.11.5+1. |
linux/packaging/rpm/make_config.yaml |
Defines RPM dependencies, metadata, and Core capabilities. |
linux/packaging/pacman/make_config.yaml |
Defines pacman metadata and install/upgrade capability hooks. |
lib/service/settings/app_update/service.dart |
Adds Microsoft Store routing and injectable update dependencies. |
lib/service/connect/startup_probe.dart |
Implements reference checks using existing batch probes. |
lib/service/connect/coordinator.dart |
Schedules session-scoped probes and exposes advisory failures. |
lib/pages/shared/connection_probe_notice.dart |
Consumes current failures and displays a toast once. |
lib/pages/main/adaptive_shell.dart |
Connects probe notices to the main app shell. |
lib/pages/connect/routing/smart/page.dart |
Adds reset controls and refreshes nested forms. |
lib/pages/connect/routing/smart/controller.dart |
Resets drafts and rejects outdated selection results. |
lib/l10n/app_zh.arb |
Adds the Simplified Chinese probe notice. |
lib/l10n/app_zh_Hant.arb |
Adds the Traditional Chinese probe notice. |
lib/l10n/app_ru.arb |
Adds the Russian probe notice. |
lib/l10n/app_fa.arb |
Adds the Persian probe notice. |
lib/l10n/app_en.arb |
Adds the English probe notice and translation context. |
docs/xray-configuration.md |
Defines probe scope, lifecycle, and advisory limitations. |
docs/validation.md |
Documents reset, probe, and update verification scenarios. |
docs/app.md |
Documents reset behavior, connection notices, and update destinations. |
build_scripts/verify_release.py |
Requires RPM and pacman artifacts for both Linux architectures. |
build_scripts/tests/test_release.py |
Tests release rejection when Linux packages are missing. |
build_scripts/tests/test_builder.py |
Tests four-format packaging, failures, and artifact collection. |
build_scripts/README.md |
Documents Linux tooling, packages, installation, and capabilities. |
build_scripts/app/linux.py |
Builds and collects RPM/pacman alongside ZIP/DEB. |
build_scripts/app/builder.py |
Supports selecting a separate Fastforge executable. |
.github/workflows/build.yml |
Installs Linux packaging tools and uploads all four formats. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Prepare OneXray 26.11.5.
Evidence
After: The editor restores defaults without persisting until Save; probe results are advisory; all four Linux package formats are collected and required for release.
git diff --checkpassed.Merge Danger
Door: Two-way
No database migrations. Smart defaults persist only through the existing Save flow. The reference probe checks node chains with a temporary Core; it does not establish actual VPN tunnel health.
Blast Radius: App
Smart routing editing, update navigation, connection feedback and Linux packaging/release selection. Linux CI adds a pinned upstream native Fastforge prerelease for pacman only.