fix: inherit stored task context id - #1208
Draft
samrusani wants to merge 1 commit into
Draft
Conversation
🧪 Code Coverage (vs
|
| Base | PR | Delta | |
|---|---|---|---|
| src/a2a/server/request_handlers/default_request_handler_v2.py | 94.25% | 94.35% | 🟢 +0.10% |
| Total | 93.12% | 93.12% | ⚪️ 0.00% |
Generated by coverage-comment.yml
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
When a V2 message continues an existing task with
taskIdbut omitscontextId, the handler fetches the stored task but previously allowed therequest context to generate a new context ID.
This patch carries the stored task's context ID into request-context
construction while continuing to defer loading the mutable task into the
executor context. A focused regression verifies that both the request context
and message retain the stored conversation context.
Validation:
Pre-fix regression failed because a generated UUID replaced
stored_context.Focused regression: 1 passed.
V2 request-handler suite: 65 passed.
./scripts/lint.sh: passed (three pre-existingtyunused-ignore warnings).uv run pytest: 1970 passed, 90 skipped, 3 xfailed, 1 xpassed.uv run pytest --cov=src --cov-report=term-missing: 1970 passed, 90 skipped,3 xfailed, 1 xpassed. Database-backed tests skipped because their optional
test DSNs were not configured.
Follow the
CONTRIBUTINGGuide.Make the Pull Request title follow the Conventional Commits specification.
Ensure the tests and linter pass.
Appropriate docs were updated (not needed for this behavioral fix).
Fixes #1206 🦕