Repository navigation
mcpclient: report why a stdio server exited when the pipe breaks first - #4
Merged
Merged
Conversation
A server that exits at once (bad config, missing token) can break the pipe before the client reads its exit; the write error then hid the server's stderr. Wait briefly for the exit and report it, as the read path does. Fixes TestStdioServerThatExits flaking on CI (main, 258cfcf). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI on main failed after #3 in
TestStdioServerThatExits:initialize: write |1: broken pipe.A stdio MCP server that exits immediately (bad config, missing token) can break the pipe before the client has read its exit. The write error then hid the server's own stderr, which is the part that tells the operator what went wrong. Now a failed write waits up to 2s for the server to exit and reports its stderr, the same way the read path already does.
Verified with
go test -race -count=30 -run TestStdioServerThatExits ./internal/mcpclient(30 of 30 passed).Needed before tagging v0.3.0.
🤖 Generated with Claude Code