Repository navigation
fix: harden DICOM and API error handling - #2
Merged
Merged
Conversation
|
You have reached your Codex usage limits for code reviews. You can see your limits in the Codex usage dashboard. |
There was a problem hiding this comment.
Copilot review overview
🟡 Changes recommended
Unresolved moderate issues affect error handling, validation consistency, and diagnostics.
Get a fresh assessment by requesting another Copilot review.
Review effort: Lite
Findings: 2
Open (2)
What changed in this PR
Hardens DICOM and API error handling, makes audit persistence mostly non-fatal, and adds device ID validation.
Changes:
- Validates positive IDs for GET device requests.
- Converts unexpected DICOM failures to generic 500 responses.
- Makes most audit persistence failures non-fatal.
| File | Summary | Findings |
|---|---|---|
Program.cs |
Updates device validation, DICOM error handling, and audit persistence. | Moderate (4): Route streamed-size audit writes through TryAuditAsync.Moderate (3): Validate IDs consistently for PUT and DELETE. Moderate (1): Log audit persistence failures. Moderate (1): Log unexpected DICOM exceptions before returning 500. Nit (1): Add boundary integration tests for zero and negative IDs. |
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+132
to
+135
| if (id <= 0) | ||
| { | ||
| return Results.BadRequest(new { message = "Device ID must be greater than zero." }); | ||
| } |
| if (request.ContentLength is > MaxDicomUploadBytes) | ||
| { | ||
| await repository.AddAuditEventAsync("dicom.inspect", "payload-too-large", cancellationToken); | ||
| await TryAuditAsync(repository, "dicom.inspect", "payload-too-large", cancellationToken); |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Contain unexpected DICOM processing failures, make audit persistence non-fatal to API requests, and reject invalid device ids.