Skip to content

Use reclient for Alpine Linux CMake builds and unify Linux CMake CI config. #2280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
copybara-service merged 1 commit into from
Oct 22, 2026
Merged

Use reclient for Alpine Linux CMake builds and unify Linux CMake CI config. #2280

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -95,7 +95,7 @@
toolchain: clang-arm
remote_config: remote-arm
stds: '["c++17", "c++20"]'
uses: ./.github/workflows/bazel.yml

Check warning on line 98 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

secrets-inherit 

ci.yml:98: secrets unconditionally inherited by called workflow: this reusable workflow
secrets: inherit
with:
os: ${{ matrix.config.os || 'ubuntu-24.04' }}
Expand All @@ -119,7 +119,7 @@
# linux_gcc_alpine_cmake.cfg
- name: Alpine Linux GCC (musl)
os: ubuntu-24.04
container_image: gcr.io/google.com/absl-177019/alpine@sha256:ae26b80601cebb14595056a94e070f0f865d24baaf3ce19bcd52f53be9f99c80
container_image: gcr.io/google.com/absl-177019/alpine@sha256:52945833fc7b7b93f73ec865eb82390aa46d4e3acd1af87d253cd4a05f95d241
build_types: '["Debug"]'
link_modes: '["static"]'
# cmake-install.cfg
Expand All @@ -139,7 +139,7 @@
os: windows-2022
build_types: '["Debug"]'
link_modes: '["static", "shared"]'
uses: ./.github/workflows/cmake.yml

Check warning on line 142 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

secrets-inherit 

ci.yml:142: secrets unconditionally inherited by called workflow: this reusable workflow
secrets: inherit
with:
os: ${{ matrix.config.os }}
Expand Down Expand Up @@ -167,7 +167,7 @@
toolchain: windows-clangcl
stds: '["c++17"]'
compilation_modes: '["fastbuild"]'
uses: ./.github/workflows/bazel.yml

Check warning on line 170 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

secrets-inherit 

ci.yml:170: secrets unconditionally inherited by called workflow: this reusable workflow
secrets: inherit
with:
os: windows-2022
Expand All @@ -188,7 +188,7 @@
# macos_xcode_alternate_options_bazel.cfg
- name: Xcode Alternate Options
alternate_options: true
uses: ./.github/workflows/bazel.yml

Check warning on line 191 in .github/workflows/ci.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

secrets-inherit 

ci.yml:191: secrets unconditionally inherited by called workflow: this reusable workflow
secrets: inherit
with:
os: macos-latest
Expand Down
18 changes: 9 additions & 9 deletions .github/workflows/cmake.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -70,13 +70,13 @@
CFLAGS: ${{ !inputs.install_test && startsWith(inputs.os, 'ubuntu') && '-Werror' || '' }}
CXX: ${{ startsWith(inputs.os, 'ubuntu') && 'g++' || '' }}
CXXFLAGS: ${{ !inputs.install_test && (startsWith(inputs.os, 'ubuntu') && '-Werror' || startsWith(inputs.os, 'windows') && '-WX') || '' }}
CMAKE_BUILD_PARALLEL_LEVEL: ${{ contains(inputs.container_image, 'oss-linux') && 50 || 16 }}
CMAKE_C_COMPILER_LAUNCHER: ${{ contains(inputs.container_image, 'oss-linux') && 'rewrapper' || 'sccache' }}
CMAKE_CXX_COMPILER_LAUNCHER: ${{ contains(inputs.container_image, 'oss-linux') && 'rewrapper' || 'sccache' }}
CMAKE_TEST_LAUNCHER: ${{ contains(inputs.container_image, 'oss-linux') && 'rbe_test_launcher' || '' }}
CMAKE_BUILD_PARALLEL_LEVEL: ${{ startsWith(inputs.os, 'ubuntu') && 50 || 16 }}
CMAKE_C_COMPILER_LAUNCHER: ${{ startsWith(inputs.os, 'ubuntu') && 'rewrapper' || 'sccache' }}
CMAKE_CXX_COMPILER_LAUNCHER: ${{ startsWith(inputs.os, 'ubuntu') && 'rewrapper' || 'sccache' }}
CMAKE_TEST_LAUNCHER: ${{ startsWith(inputs.os, 'ubuntu') && 'rbe_test_launcher' || '' }}
CMAKE_GENERATOR: Ninja
CTEST_OUTPUT_ON_FAILURE: 1
CTEST_PARALLEL_LEVEL: ${{ contains(inputs.container_image, 'oss-linux') && 50 || 16 }}
CTEST_PARALLEL_LEVEL: ${{ startsWith(inputs.os, 'ubuntu') && 50 || 16 }}
TZDIR: ${{ github.workspace }}/absl/time/internal/cctz/testdata/zoneinfo
RBE_service: us-east1-remotebuildexecution.googleapis.com:443
RBE_instance: projects/google.com:absl-177019/instances/absl-ci-east
Expand All @@ -90,7 +90,7 @@
SCCACHE_IGNORE_SERVER_IO_ERROR: 1
steps:
- name: Checkout
uses: actions/checkout@9c091bb21b7c1c1d1991bb908d89e4e9dddfe3e0 # 7.0.0

Check warning on line 93 in .github/workflows/cmake.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

ref-version-mismatch 

cmake.yml:93: action's hash pin has mismatched or missing version comment: points to unknown ref

- name: Set up MSVC
if: ${{ runner.os == 'Windows' }}
Expand All @@ -106,17 +106,17 @@
credentials_json: ${{ secrets.GAR_SERVICE_ACCOUNT }}

- name: Set up sccache
if: ${{ !contains(inputs.container_image, 'oss-linux') }}
if: ${{ runner.os != 'Linux' }}
uses: mozilla-actions/sccache-action@9e7fa8a12102821edf02ca5dbea1acd0f89a2696 # v0.0.10

- name: Start sccache
if: ${{ !contains(inputs.container_image, 'oss-linux') }}
if: ${{ runner.os != 'Linux' }}
env:
SCCACHE_GCS_KEY_PATH: ${{ steps.auth.outputs.credentials_file_path }}
run: sccache --start-server

- name: Start reclient (RBE)
if: ${{ contains(inputs.container_image, 'oss-linux') }}
if: ${{ runner.os == 'Linux' }}
run: |
# CMake passes absolute source/include paths (${GITHUB_WORKSPACE}/...) to
# the compiler, so mount the remote input root at that same container path.
Expand All @@ -139,7 +139,7 @@
cmake -B build
-DABSL_BUILD_TESTING=ON
-DABSL_GOOGLETEST_DOWNLOAD_URL=${ABSL_GOOGLETEST_DOWNLOAD_URL}
-DCMAKE_BUILD_TYPE=${{ matrix.build_type }}

Check failure on line 142 in .github/workflows/cmake.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

zizmor/template-injection 

code injection via template expansion: may expand into attacker-controllable code

Check failure on line 142 in .github/workflows/cmake.yml

View workflow job for this annotation

GitHub Actions / zizmor-output

template-injection 

cmake.yml:142: code injection via template expansion: may expand into attacker-controllable code
-DCMAKE_C_FLAGS_DEBUG="${{ runner.os == 'Windows' && '-O1 -Ob1 -Zc:inline' || '-Og' }}"
-DCMAKE_CXX_FLAGS_DEBUG="${{ runner.os == 'Windows' && '-O1 -Ob1 -Zc:inline' || '-Og' }}"
-DCMAKE_EXE_LINKER_FLAGS_DEBUG=""
Expand All @@ -164,5 +164,5 @@
${{ runner.os == 'Windows' && '-E "absl_lifetime_test|absl_symbolize_test"' || '' }}

- name: Stop reclient (RBE)
if: ${{ always() && contains(inputs.container_image, 'oss-linux') }}
if: ${{ always() && runner.os == 'Linux' }}
run: bootstrap --shutdown
Loading