Skip to content

fix: declare api_endpoint applicability for demo bootstrap execute capability - #114

Merged
dborovcanin merged 3 commits into
mainfrom
fix/demo-bootstrap-api-endpoint-applicability
Sep 16, 2026
Merged

dborovcanin merged 3 commits into
mainfrom
fix/demo-bootstrap-api-endpoint-applicability

Conversation

@felixgateru

@felixgateru felixgateru commented Sep 11, 2026

Copy link
Copy Markdown
Contributor

Problem

  • migration 001 persists execute/api_endpoint applicability, but config/demo/bootstrap.yaml never declared it, so bootstrap rejects the pre-existing row and startup fails: bootstrap capability execute has persisted applicability not declared in config: api_endpoint:<any>. Blocks make up on any already-migrated database.

Fix

  • declare object_kind: api_endpoint on the demo execute capability, matching the persisted row
  • document the data-preserving recovery step in the bootstrap file's header for anyone who already hit the error — no manual DB change needed, just redeploy the fixed config
  • add a parity test that loads the real demo config and proves it reconciles against a freshly migrated database, twice (idempotence)

Tests

  • cargo fmt --check / cargo clippy -- -D warnings clean
  • new test fails with the exact issue error text when reverted, passes once fixed
  • real cargo run against a fresh migrated DB applies the demo bootstrap cleanly

Part of #110 (workstream C).

…ability so it matches the migration-seeded database contract

Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
…ady hit the undeclared api_endpoint applicability error

Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@arvindh123

Copy link
Copy Markdown
Contributor

@codex review

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Sep 16, 2026

Copy link
Copy Markdown

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review Completed 2026-09-16T06:17:43.951456Z c01cc60 Manual request
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex Review: Didn't find any major issues. Another round soon, please!

Reviewed commit: c01cc6075b

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

Comment thread tests/m26_config_managed_capabilities.rs Outdated
…tibility, not exact equality

Signed-off-by: Felix Gateru <felix.gateru@gmail.com>
@felixgateru
felixgateru force-pushed the fix/demo-bootstrap-api-endpoint-applicability branch from 72d3fb8 to 3dd153b Compare September 16, 2026 07:37
@dborovcanin
dborovcanin merged commit b7eb949 into main Sep 16, 2026
4 checks passed
@dborovcanin
dborovcanin deleted the fix/demo-bootstrap-api-endpoint-applicability branch September 16, 2026 07:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants