Repository navigation
feat(creator-keys): restrict early access toggle to creator and emit … - #935
Merged
Chucks1093 merged 6 commits intoOct 1, 2026
Merged
Chucks1093 merged 6 commits into
Chucks1093 merged 6 commits into
Conversation
…event set_early_access_mode is now creator-only and emits EarlyAccessModeChangedEvent with the new state. Tests cover the admin rejection and the toggle event. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
|
@sarah-obasi-analytics Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
cargo fmt --check was failing with an unclosed-delimiter parse error. The if caller != creator block was missing its closing brace, with a leftover assert_creator_or_admin call bleeding into it from before the creator-only restriction was added. Tests already assert admin gets Unauthorized here, so the fix removes that stray call and closes the brace rather than restoring admin access. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
Clippy with -D warnings failed on unused-import errors: the file had
two separate testutils::{...} use blocks left over from a prior merge,
making the second one's Address/Events bindings fully redundant with
the first. Collapsed to a single import.
Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
…event
set_early_access_mode is now creator-only and emits EarlyAccessModeChangedEvent with the new state. Tests cover the admin rejection and the toggle event.
Summary
closes #918
Testing
cargo fmt --all -- --checkcargo clippy --workspace --all-targets -- -D warningscargo test --workspaceChecklist
creator-keysunit/integration tests for every changed contract behavior, including failure paths for new or reachableContractErrorvariantscargo fmt --all -- --check,cargo clippy --workspace --all-targets -- -D warnings, andcargo test --workspace, or explained exactly why a command was not rundocs/storage-key-invariants.md; any storage layout change includes a migration/backward-compatibility notedocs/contract-event-conventions.md, or documented the breaking change and versioning plan