Skip to content

fix(scripts): write the release timestamp to GITHUB_OUTPUT - #324

Open
Megh-Shah-08 wants to merge 1 commit into
accordproject:mainfrom
Megh-Shah-08:fix-scripts-timestamp
Open

Megh-Shah-08 wants to merge 1 commit into
accordproject:mainfrom
Megh-Shah-08:fix-scripts-timestamp

Conversation

@Megh-Shah-08

Copy link
Copy Markdown

Closes #323

Changes

  • Replaces deprecated ::set-output syntax in scripts/timestamp.js with direct append writing to process.env.GITHUB_OUTPUT.
  • Maintains console fallback when executed outside GitHub Actions environments.

Flags

Related Issues

Author Checklist

  • Ensure you provide a DCO sign-off for your commits using the --signoff option of git commit.
  • Vital features and changes captured in unit and/or integration tests
  • Commits messages follow AP format
  • Extend the documentation, if necessary
  • Merging to main from fork:branchname

Replaces deprecated ::set-output workflow command in scripts/timestamp.js with direct append writing to GITHUB_OUTPUT, maintaining console fallback when running outside GitHub Actions.

Follows PR accordproject#297 and accordproject/concerto#1324.

Signed-off-by: Megh-Shah-08 <meghshah810@gmail.com>
Copilot AI balanced review requested due to automatic review settings November 15, 2026 10:56

Copilot AI left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.

An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.

@mira-accord-project

Copy link
Copy Markdown

Thank you for opening this pull request and for picking up issue #323. Switching scripts/timestamp.js from the deprecated ::set-output syntax to a write to GITHUB_OUTPUT, with a console fallback outside GitHub Actions, follows the same approach as the merged change in #297 for scripts/tag.js. Review has been requested from Jamie Shorten and Sanket Shevkar, who maintain concerto-codegen. The CI runs are waiting for a maintainer to approve them, which is normal for a first contribution, so they will start once that is done. If anything in the change needs explaining in the meantime, please ask here.


Posted automatically by Mira, an Accord Project agent. A maintainer will follow up; they make the decisions on this.

@mira-accord-project mira-accord-project Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for this fix, and for linking it to #323. It replaces the deprecated ::set-output command in scripts/timestamp.js with an append of stamp=<version> to GITHUB_OUTPUT. It keeps a console fallback for running outside GitHub Actions, and follows the same pattern as scripts/tag.js. I found nothing to change. The output line is newline-terminated and in valid key=value form, the licence header is intact, and the commit has a matching DCO sign-off. The fallback prints stamp=<version> rather than the bare value, which suits a script that sets a named output. This looks ready to merge once a maintainer approves.

No problems found.


Automated review by Mira, an Accord Project agent, at ab681cb. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

fix(scripts): timestamp.js uses deprecated ::set-output syntax

2 participants