Repository navigation
fix(scripts): write the release timestamp to GITHUB_OUTPUT - #324
Megh-Shah-08 wants to merge 1 commit into
Conversation
Replaces deprecated ::set-output workflow command in scripts/timestamp.js with direct append writing to GITHUB_OUTPUT, maintaining console fallback when running outside GitHub Actions. Follows PR accordproject#297 and accordproject/concerto#1324. Signed-off-by: Megh-Shah-08 <meghshah810@gmail.com>
There was a problem hiding this comment.
Copilot was unable to review this pull request because the user who requested the review has insufficient remaining quota. Try requesting a review at a lower effort level.
An organization owner can choose the repository organization as the billing source for reviews requested by members with a paid Copilot license. Learn about Copilot code review billing.
|
Thank you for opening this pull request and for picking up issue #323. Switching scripts/timestamp.js from the deprecated ::set-output syntax to a write to GITHUB_OUTPUT, with a console fallback outside GitHub Actions, follows the same approach as the merged change in #297 for scripts/tag.js. Review has been requested from Jamie Shorten and Sanket Shevkar, who maintain concerto-codegen. The CI runs are waiting for a maintainer to approve them, which is normal for a first contribution, so they will start once that is done. If anything in the change needs explaining in the meantime, please ask here. Posted automatically by Mira, an Accord Project agent. A maintainer will follow up; they make the decisions on this. |
There was a problem hiding this comment.
Thank you for this fix, and for linking it to #323. It replaces the deprecated ::set-output command in scripts/timestamp.js with an append of stamp=<version> to GITHUB_OUTPUT. It keeps a console fallback for running outside GitHub Actions, and follows the same pattern as scripts/tag.js. I found nothing to change. The output line is newline-terminated and in valid key=value form, the licence header is intact, and the commit has a matching DCO sign-off. The fallback prints stamp=<version> rather than the bare value, which suits a script that sets a named output. This looks ready to merge once a maintainer approves.
No problems found.
Automated review by Mira, an Accord Project agent, at ab681cb. Findings are labelled blocking, should-fix or nit; a maintainer makes the final call.
Closes #323
Changes
::set-outputsyntax inscripts/timestamp.jswith direct append writing toprocess.env.GITHUB_OUTPUT.Flags
scripts/tag.js.Related Issues
Author Checklist
--signoffoption of git commit.mainfromfork:branchname