Skip to content

chore: migrate model build to Concerto 5 - #204

Merged
mttrbrts merged 1 commit into
mainfrom
mttrbrts-models-dependency-scan
Sep 14, 2026
Merged

mttrbrts merged 1 commit into
mainfrom
mttrbrts-models-dependency-scan

Conversation

@mttrbrts

Copy link
Copy Markdown
Member

Summary

  • replace the Concerto 4 build bucket with Concerto 5
  • upgrade root Concerto dependencies to @accordproject/concerto-core@^5.0.0 and v5-compatible @accordproject/concerto-codegen@^6.3.0
  • parse and generate money-reference@1.0.0 exclusively with Concerto 5
  • regenerate the npm lockfile without retaining Concerto 4 aliases

Validation

  • npm ci on Node 24
  • npm run build (122 indexed models processed; all 123 CTO sources copied; no model or generator diagnostics)

No test, fixture, or snapshot files changed.

Co-authored-by: Copilot App <223556219+Copilot@users.noreply.github.com>
Signed-off-by: Matt Roberts <code@rbrts.uk>
@github-actions

Copy link
Copy Markdown

🧩 Concerto Playground Preview

The .cto model changes in this PR are pre-loaded into the Concerto Playground — click a link below for a live preview.

File Preview
src/money-reference@1.0.0.cto Diagram · Code · Open in Playground

Auto-generated from commit c9701e5. Updates automatically on new commits.

@mttrbrts
mttrbrts enabled auto-merge (squash) September 14, 2026 15:51
@mttrbrts
mttrbrts merged commit a23b30a into main Sep 14, 2026
3 checks passed
@mttrbrts
mttrbrts deleted the mttrbrts-models-dependency-scan branch September 14, 2026 15:56
mttrbrts pushed a commit that referenced this pull request Sep 30, 2026
Resolves the conflict with the Concerto 5 build migration (#204).

concertoVersions.js, package.json and package-lock.json take main's
side wholesale: this branch's only change to them added a 4.x slot
pinned to 4.2.0, and #204 replaces the 4.x slot with 5.0.0 outright.

The textual conflict hid a semantic one. findCompatibleVersion matches
a slot key against the model's declared range, so with the slots now
2.0.0, 3.6.0 and 5.0.0, the four models declaring a Concerto 4 floor
matched nothing and fell back to defaultVersion 2.0.0, which cannot
parse their map types. agreement@1.0.0, obligation@1.0.0,
obligation/settlement@1.0.0 and runtime@1.0.0 therefore move to
^5.0.0, following the same caret bump #204 applied to
money-reference@1.0.0. Their comments keep the reason for the floor,
including runtime's dependency on the cross-namespace map value fix
from 4.2.0 (accordproject/concerto#1279), and now say that the
declared floor tracks the release the build supports.

party@1.0.0, template@1.0.0 and templatedata@1.0.0 keep ^3.0.0: they
declare no map type and still resolve to the 3.6.0 slot.

Verified under concerto-core 5.0.0: all nine namespaces parse and
validate, each of the four models resolves to the 5.0.0 slot, a
cross-namespace map value round-trips with its $class preserved, and
the optional hash properties remain omittable.

Co-Authored-By: Claude Opus 5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01NPtNYorvvn7MQwTovLXp2r
Signed-off-by: Matt Roberts <matt@rbrts.uk>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant