Skip to content

ci(e2e): upgrade Playwright to 1.65 so the e2e job runs on Ubuntu 26.04 - #226

Merged
mttrbrts merged 1 commit into
accordproject:mainfrom
ujjwalv01:ci/playwright-ubuntu-26
Nov 14, 2026
Merged

mttrbrts merged 1 commit into
accordproject:mainfrom
ujjwalv01:ci/playwright-ubuntu-26

Conversation

@ujjwalv01

Copy link
Copy Markdown
Contributor

Description

Fixes #225.

The Browser E2E (Chromium) job fails on every pull request at "Install Playwright Chromium", before any test runs (for example on #224):

BEWARE: your OS is not officially supported by Playwright; installing dependencies for ubuntu26.04-x64 as a fallback.
Cannot install dependencies for ubuntu26.04-x64 with Playwright 1.60.0!
Error: ERROR: Playwright does not support chromium on ubuntu26.04-x64

ubuntu-latest now resolves to Ubuntu 26.04 (runner image 20261111.196.1), and the lockfile resolved @playwright/test ^1.49.0 to 1.60.0, which has no Ubuntu 26.04 entry in its supported-OS table. Playwright added one in 1.61.0 (packages/playwright-core/src/server/registry/nativeDeps.ts has no ubuntu26.04-x64 at the 1.60.0 tag and has it from 1.61.0 on). main's last e2e run (2026-11-06) predates the image change.

This bumps @playwright/test in e2e/package.json to ^1.65.1, the current release, so the job keeps running on ubuntu-latest. The workflow is unchanged: it already keys the browser cache by the Playwright version, so the first run downloads the new Chromium and later runs hit the cache. Pinning the runner to ubuntu-24.04 would also unblock CI but only defers the same failure to when that image is retired.

The e2e workspace and this job come from #157, which added the webpack browser build and the Playwright suite that loads it; nothing in that design changes here.

Commits

  • ci(e2e): upgrade Playwright to 1.65 so the e2e job runs on Ubuntu 26.04: e2e/package.json and package-lock.json.

Compatibility

None for users of the package. The lockfile changes only @playwright/test, playwright and playwright-core (1.60.0 → 1.65.1) and drops a nested fsevents that the new version no longer depends on. The e2e specs are unchanged and pass on the new version.

Testing

Node 24, Windows 11, on this branch:

  • npm test (licence check, lint, build, jest): 19/19 suites, 193/193 tests, 46/46 snapshots pass.
  • npm run build:dist: TypeScript and the webpack UMD build complete.
  • npx playwright install chromium with Playwright 1.65.1, then npx playwright test --config e2e/playwright.config.ts: 6/6 Chromium tests pass (the three UMD tests and the three SDK-loader tests).

ubuntu-latest now resolves to Ubuntu 26.04, which Playwright 1.60.0 does not support, so the Browser E2E job fails before any test runs. Playwright 1.61.0 added Ubuntu 26.04; this moves @playwright/test to ^1.65.1 and keeps the workflow unchanged.

Fixes accordproject#225

Signed-off-by: Ujjwal Verma <ujjwalverma010305@gmail.com>
@ujjwalv01
ujjwalv01 requested a review from a team November 14, 2026 18:38
@mttrbrts
mttrbrts enabled auto-merge (squash) November 14, 2026 18:38
@mttrbrts
mttrbrts merged commit 6dc5b02 into accordproject:main Nov 14, 2026
9 checks passed
@coveralls

Copy link
Copy Markdown

Coverage Report for CI Build 43627719707

Warning

Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes.
Quick fix: rebase this PR. Learn more →

Coverage remained the same at 73.195%

Details

  • Coverage remained the same as the base build.
  • Patch coverage: No coverable lines changed in this PR.
  • No coverage regressions found.

Uncovered Changes

No uncovered changes found.

Coverage Regressions

No coverage regressions found.


Coverage Stats

Coverage Status
Relevant Lines: 1596
Covered Lines: 1277
Line Coverage: 80.01%
Relevant Branches: 1146
Covered Branches: 730
Branch Coverage: 63.7%
Branches in Coverage %: Yes
Coverage Strength: 3005.46 hits per line

💛 - Coveralls

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ci: Browser E2E job fails on ubuntu-latest (Ubuntu 26.04) because Playwright 1.60.0 does not support it

3 participants