Repository navigation
ci(e2e): upgrade Playwright to 1.65 so the e2e job runs on Ubuntu 26.04 - #226
Merged
Merged
Conversation
ubuntu-latest now resolves to Ubuntu 26.04, which Playwright 1.60.0 does not support, so the Browser E2E job fails before any test runs. Playwright 1.61.0 added Ubuntu 26.04; this moves @playwright/test to ^1.65.1 and keeps the workflow unchanged. Fixes accordproject#225 Signed-off-by: Ujjwal Verma <ujjwalverma010305@gmail.com>
mttrbrts
approved these changes
Nov 14, 2026
mttrbrts
enabled auto-merge (squash)
November 14, 2026 18:38
Coverage Report for CI Build 43627719707Warning Build has drifted: This PR's base is out of sync with its target branch, so coverage data may include unrelated changes. Coverage remained the same at 73.195%Details
Uncovered ChangesNo uncovered changes found. Coverage RegressionsNo coverage regressions found. Coverage Stats💛 - Coveralls |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Fixes #225.
The
Browser E2E (Chromium)job fails on every pull request at "Install Playwright Chromium", before any test runs (for example on #224):ubuntu-latestnow resolves to Ubuntu 26.04 (runner image20261111.196.1), and the lockfile resolved@playwright/test^1.49.0to 1.60.0, which has no Ubuntu 26.04 entry in its supported-OS table. Playwright added one in 1.61.0 (packages/playwright-core/src/server/registry/nativeDeps.tshas noubuntu26.04-x64at the 1.60.0 tag and has it from 1.61.0 on).main's last e2e run (2026-11-06) predates the image change.This bumps
@playwright/testine2e/package.jsonto^1.65.1, the current release, so the job keeps running onubuntu-latest. The workflow is unchanged: it already keys the browser cache by the Playwright version, so the first run downloads the new Chromium and later runs hit the cache. Pinning the runner toubuntu-24.04would also unblock CI but only defers the same failure to when that image is retired.The e2e workspace and this job come from #157, which added the webpack browser build and the Playwright suite that loads it; nothing in that design changes here.
Commits
ci(e2e): upgrade Playwright to 1.65 so the e2e job runs on Ubuntu 26.04:e2e/package.jsonandpackage-lock.json.Compatibility
None for users of the package. The lockfile changes only
@playwright/test,playwrightandplaywright-core(1.60.0 → 1.65.1) and drops a nestedfseventsthat the new version no longer depends on. The e2e specs are unchanged and pass on the new version.Testing
Node 24, Windows 11, on this branch:
npm test(licence check, lint, build, jest): 19/19 suites, 193/193 tests, 46/46 snapshots pass.npm run build:dist: TypeScript and the webpack UMD build complete.npx playwright install chromiumwith Playwright 1.65.1, thennpx playwright test --config e2e/playwright.config.ts: 6/6 Chromium tests pass (the three UMD tests and the three SDK-loader tests).