feat: add bounded client retry for admission rejections - #3
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional bounded client-side retry for retryable admission rejections.
The coordinator already returns a typed
SUBMIT_REJECTEDresponse when the active-job admission limit is reached. This change allows clients to optionally retry those side-effect-free rejections using bounded exponential backoff with full jitter.Retry remains disabled by default.
What changed
ClientRetryPolicySubmitRetrierSubmitRejectedException.retryable()to honor the wire-providedretryableflag--submit-retries--submit-retry-base-millis--submit-retry-max-millisSafety semantics
Automatic retry is limited to typed
SUBMIT_REJECTEDresponses withretryable=true.Transport or protocol failures are intentionally not retried automatically because the client cannot know whether the coordinator accepted the submission before the connection failed. Blindly resending in that case could create duplicate jobs.
Verification
./mvnw clean verify— BUILD SUCCESSgit diff --check— clean