feat: add durable idempotent job submissions - #4
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds optional durable idempotency keys for client job submissions.
A client may now associate a stable idempotency key with a logical submission. Repeating the same submission with the same key returns the original job ID instead of creating another logical job.
The mapping is persisted in SQLite and restored after coordinator restart.
What changed
idempotencyKeytoSubmitJob--idempotency-keySemantics
Important limitation
This provides submission deduplication only.
It does not provide exactly-once task execution. Worker execution remains at-least-once.
Automatic retry of ambiguous transport failures is also still intentionally disabled.
Verification
./mvnw clean verify— BUILD SUCCESSgit diff --check— clean