Repository navigation
Remove 'searchbox' from label in name background - #2448
Merged
Merged
Conversation
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
shunguoy
approved these changes
Sep 3, 2026
Collaborator
|
Need for Call for Review: none, PR is editorial.
…________________________________
How to Review And Approve
* Go to the “Files changed” tab
* Here you will have the option to leave comments on different lines.
* Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
* Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.
________________________________
You can view, comment on, or merge this pull request online at:
#2450
Commit Summary
*
Rule bc4a75<https://www.w3.org/WAI/standards-guidelines/act/rules/bc4a75/proposed/>
File Changes
*
https://github.com/act-rules/act-rules.github.io/pull/2450/changes
|
shunguoy
reviewed
Sep 4, 2026
| ## Background | ||
|
|
||
| This rule applies to elements with a [widget role][] that [support name from content][supports name from content]. This includes the following: `button`, `checkbox`, `gridcell`, `link`, `menuitem`, `menuitemcheckbox`, `menuitemradio`, `option`, `radio`, `searchbox`, `switch`, `tab`, `treeitem`. | ||
| This rule applies to elements with a [widget role][] that [support name from content][supports name from content]. This includes the following: `button`, `checkbox`, `gridcell`, `link`, `menuitem`, `menuitemcheckbox`, `menuitemradio`, `option`, `radio`, `switch`, `tab`, `treeitem`. |
Collaborator
There was a problem hiding this comment.
Just wondering if this rule should be expanded to include all the labelable elements ? If a labelable element takes a role which has an author-supplied accessible name other than from label itself, then same requirement is applied. It's fine for a new issue, rather than included in the current one.
Member
Author
There was a problem hiding this comment.
Maybe, but not in this PR.
giacomo-petri
approved these changes
Oct 2, 2026
G0dwin
approved these changes
Oct 5, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Searchbox is not named from content as the section says.
Need for Call for Review: none, PR is editorial.
How to Review And Approve