Skip to content

Update role-required-states-and-properties per ARIA 1.3 - #2466

Open
shunguoy wants to merge 16 commits into
developfrom
aria1.3-4e8ab6
Open

shunguoy wants to merge 16 commits into
developfrom
aria1.3-4e8ab6

Conversation

@shunguoy

Copy link
Copy Markdown
Collaborator

<< Describe the changes >>

Closes issue(s):

Need for Call for Review:

This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of examples, if in doubt, use this.


Pull Request Etiquette

When creating PR:

  • Make sure you're requesting to pull a branch (right side) to the develop branch (left side).
  • Make sure you do not remove the "How to Review and Approve" section in your pull request description

After creating PR:

  • Add yourself (and co-authors) as "Assignees" for PR.
  • Add label to indicate if it's a Rule, Definition or Chore.
  • Link the PR to any issue it solves. This will be done automatically by referencing the issue at the top of this comment in the indicated place.
  • Optionally request feedback from anyone in particular by assigning them as "Reviewers".
  • If your PR is for a new rule with an Accessibility Support note, or for updating the Accessibility Support note of an existing section, make sure to open a corresponding Accessibility Support issue.

When merging a PR:

  • Close any issue that the PR resolves. This will happen automatically upon merging if the PR was correctly linked to the issue, e.g. by referencing the issue at the top of this comment.

How to Review And Approve

  • Go to the “Files changed” tab
  • Here you will have the option to leave comments on different lines.
  • Once the review is completed, find the “Review changes” button in the top right, select “Approve” (if you are really confident in the rule) or "Request changes" and click “Submit review”.
  • Make sure to also review the proposed Call for Review period. In case of disagreement, the longer period wins.

@shunguoy shunguoy self-assigned this Oct 21, 2026
@shunguoy shunguoy added Rule Use this label for a new rule that does not exist already WAI-ARIA 1.3 labels Oct 21, 2026
@netlify

netlify Bot commented Oct 21, 2026 •

Copy link
Copy Markdown

✅ Deploy Preview for act-rules ready!

Name Link
🔨 Latest commit 151d424
🔍 Latest deploy log https://app.netlify.com/projects/act-rules/deploys/6ae0d1a10fca576131135507
😎 Deploy Preview https://deploy-preview-2466--act-rules.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.
🤖 Make changes Run an agent on this branch

To edit notification comments on pull requests, go to your Netlify project configuration.

@shunguoy

shunguoy commented Oct 22, 2026 via email •

Copy link
Copy Markdown
Collaborator Author

Comment thread package.json Resolved
shunguoy and others added 9 commits October 22, 2026 13:12
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>

@daniel-montalvo daniel-montalvo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One question about what we state about the option role.

@daniel-montalvo daniel-montalvo left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks, much clearer now.

@daniel-montalvo

Copy link
Copy Markdown
Collaborator

Relates to #2400

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Rule Use this label for a new rule that does not exist already WAI-ARIA 1.3

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[4e8ab6]Update the examples to comply with ARIA 1.3

2 participants