Repository navigation
Conversation
shunguoy
requested review from
WilcoFiers,
dan-tripp-siteimprove and
daniel-montalvo
October 21, 2026 17:25
✅ Deploy Preview for act-rules ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Collaborator
Author
daniel-montalvo
requested changes
Oct 22, 2026
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
Co-authored-by: Daniel Montalvo <49305434+daniel-montalvo@users.noreply.github.com>
…b.io into aria1.3-4e8ab6
daniel-montalvo
requested changes
Oct 27, 2026
daniel-montalvo
left a comment
Collaborator
There was a problem hiding this comment.
One question about what we state about the option role.
daniel-montalvo
approved these changes
Oct 30, 2026
daniel-montalvo
left a comment
Collaborator
There was a problem hiding this comment.
thanks, much clearer now.
Collaborator
|
Relates to #2400 |
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
<< Describe the changes >>
Closes issue(s):
Need for Call for Review:
This will require a 2 weeks Call for Review << new rule, or substantial changes affecting a large number of examples, if in doubt, use this.
Pull Request Etiquette
When creating PR:
developbranch (left side).After creating PR:
Rule,DefinitionorChore.When merging a PR:
How to Review And Approve